Stop reimplementing $zle_highlight

[danielshahaf]

Currently z-sy-h reimplements $zle_highlight's semantics:

https://github.com/zsh-users/zsh-syntax-highlighting/blob/91d2eeaf23c47341e8dc7ad66dbf85e38c2674de/zsh-syntax-highlighting.zsh#L163-L193

Work with zsh upstream to resolve this duplication.

See https://github.com/zsh-users/zsh-syntax-highlighting/issues/418#issuecomment-649845279.

[danielshahaf]

Triage: The current approach isn't elegant, but is good enough so long as zsh doesn't extend the $zle_highlight syntax in a manner that's non-trivial to reimplement in script code, and that isn't in the offing. We can cross that bridge when we come to it. Leaving unmilestoned.

[okapia]

The layer= feature merged upstream in zsh-workers/52500 (85545af42) is intended to provide a solution to this and other related issues. There's not been any feedback. Perhaps this project's developers are better qualified to consider that new feature and other new highlighting related features?

[danielshahaf]

Thanks for the heads up, Oliver. I'm afraid I don't have the brainwidth to follow -workers@ presently, but perhaps one of the other developers can chime in. I do look forward to reading up on all the recent changes when I have time.

I did quickly grep through past interplugin interaction issues but have nothing to report.

okapia wrote on Mon, 12 Feb 2024 22:53 +00:00:

The layer= feature merged upstream in zsh-workers/52500 (85545af42) is intended to provide a solution to this and other related issues. There's not been any feedback. Perhaps this project's developers are better qualified to consider that new feature and other new highlighting related features?

-- Reply to this email directly or view it on GitHub: https://github.com/zsh-users/zsh-syntax-highlighting/issues/745#issuecomment-1939743433 You are receiving this because you authored the thread.

Message ID: @.***>