zsh-syntax-highlighting icon indicating copy to clipboard operation
zsh-syntax-highlighting copied to clipboard

WIP: Highlight history modifiers (#485)

Open danielshahaf opened this issue 5 years ago • 1 comments

This is https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-359181850, rebased and with the tests written (for reasons explained there).

Concerns:

  • [ ] https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-358833116 "Modifiers require braces when KSH_ARRAYS is set."
  • [ ] https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-358833831 Modifiers with arguments
  • [ ] The :t2/:h2 modifier (new since #485) - https://github.com/zsh-users/zsh/blob/e5765bfdc89f131d03051ba4963819fdfe252503/README#L49-L63
  • [ ] https://github.com/zsh-users/zsh-syntax-highlighting/issues/485#issuecomment-359221286 @phy1729 requested that "[some unknown referent] and the parameter handling in _highlight_arguments should be pulled out into a new function" — @phy1729, do you by chance recall what the words "that bit" referred to?

danielshahaf avatar Mar 15 '20 19:03 danielshahaf

Triage: incomplete, new feature (as opposed to bugfix), 0.8.0 has plenty of content already merged, redrawhook is the next priority: demilestone.

danielshahaf avatar May 22 '20 02:05 danielshahaf