terraform-provider-zia icon indicating copy to clipboard operation
terraform-provider-zia copied to clipboard

fix: Fixed zia_dlp_web_rules resource and documentation

Open willguibr opened this issue 6 months ago • 1 comments

Provide a general summary of your changes in the title above. You should remove this overview, any sections and any section descriptions you don't need below before submitting. There isn't a strict requirement to use this template if you can structure your description and still cover these points.

Description

Describe your changes in detail through motivation and context. Why is this change required? What problem does it solve? If it fixes an open issue, link to the issue using GitHub's closing issues keywords1.

Has your change been tested?

Explain how the change has been tested and what you ran to confirm your change affects other parts of the code. Automated tests are generally expected and changes without tests should explain why they aren't required.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [x] My change requires a change to the documentation.
  • [x] I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.
  • [x] This change is using publicly documented and stable APIs.

willguibr avatar May 13 '25 21:05 willguibr

Codecov Report

Attention: Patch coverage is 0% with 157 lines in your changes missing coverage. Please review.

Project coverage is 66.31%. Comparing base (569c0d1) to head (dce09c0).

Files with missing lines Patch % Lines
zia/validator.go 0.00% 91 Missing :warning:
zia/resource_zia_dlp_web_rules.go 0.00% 35 Missing :warning:
zia/common.go 0.00% 28 Missing :warning:
zia/resource_zia_user_management_users.go 0.00% 2 Missing :warning:
zia/data_source_zia_user_management_users.go 0.00% 1 Missing :warning:

:x: Your changes status has failed because you have indirect coverage changes. Learn more about Unexpected Coverage Changes and reasons for indirect coverage changes.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #429      +/-   ##
==========================================
- Coverage   69.89%   66.31%   -3.59%     
==========================================
  Files         115      115              
  Lines       24624    24699      +75     
==========================================
- Hits        17211    16379     -832     
- Misses       6303     7334    +1031     
+ Partials     1110      986     -124     
Files with missing lines Coverage Δ
zia/data_source_zia_cloud_applications.go 89.69% <ø> (+3.09%) :arrow_up:
zia/resource_zia_file_type_control_rules.go 49.69% <ø> (-3.43%) :arrow_down:
zia/data_source_zia_user_management_users.go 71.32% <0.00%> (ø)
zia/resource_zia_user_management_users.go 3.78% <0.00%> (ø)
zia/common.go 72.13% <0.00%> (-6.50%) :arrow_down:
zia/resource_zia_dlp_web_rules.go 2.87% <0.00%> (-43.35%) :arrow_down:
zia/validator.go 23.44% <0.00%> (-10.90%) :arrow_down:

... and 42 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar May 13 '25 21:05 codecov-commenter