string_theory some minor enhancements

some minor enhancements

Open jfmherokiller opened this issue 2 years ago • 4 comments

Nov 05 '23 00:11 jfmherokiller

Is the change to std::enable_if_t necessary? That would bump the project from requiring C++11 to C++14, no?

Nov 05 '23 01:11 dpogue

Might also be worth specifying both inline and constexpr: https://quuxplusone.github.io/blog/2022/07/08/inline-constexpr/

Nov 05 '23 01:11 dpogue

Is the change to std::enable_if_t necessary? That would bump the project from requiring C++11 to C++14, no?

it is not necessary I honestly thought it was part of the c++11 standard.

Nov 05 '23 04:11 jfmherokiller

Might also be worth specifying both inline and constexpr: https://quuxplusone.github.io/blog/2022/07/08/inline-constexpr/

that would only apply if i was changing variables plus inline constexpr seems to be a c++17 standard.

Nov 05 '23 05:11 jfmherokiller