community
community copied to clipboard
zowe
Are github branch updates removing DCO signoffs?
A few people believe they've witnessed that DCO signoffs were fine on a PR prior to clicking the button to update the branch if it is out of date with the target.
After this point, I personally have seen the green check for DCO signoff turn into a red failure where it says DCO is missing. Unless this is my imagination, it's as if this button can sometimes remove DCO. Or otherwise, the original DCO check was wrong?
Either way, if people can witness this for certain, please note the PR so that we can send this to whoever is the author of whatever tool (the DCO bot, or github itself).
Adding you John just incase this is due to behavior of github itself since I recall you helped get DCO behavior for us as a sort of pilot/beta program, you might know who to contact if we do spot an issue for sure.
This just happened. No DCO issue, then click the "update branch" button, then DCO issues on every commit. Upon checking the commits, I see that the DCO bot returned green for every commit up until the last one, in which it retroactively thinks the commits are now wrong.
https://github.com/zowe/zen/pull/84/commits
Thanks @1000TurquoisePogs. I don't see a DCO signoff on any of those commits; are you saying there were DCO signoffs on the commits and they all are gone now?
Closing the loop - I'd recommend enabling remediation commits for all repos.
https://github.com/dcoapp/app#individual-remediation-commit-support
This will make it easier to clean up DCO signoffs that are missing.