Crypt: wrong echo-message for outgoing messages

[keigel2001]

Related to: e30dfdc and #1481

I'm using TheLounge, which is reacting on the echo-message and putting it into my view/timeline. Right now when I write something, I get the encrypted value back as reply. I would've expected to get the unencrypted message back (the same one, that I actually have written).

testmessage: PRIVMSG #testing TEST echo-reply: @time=2019-01-07T10:18:07.531Z :keigel2001!~keigel2k1@p... PRIVMSG #testing :+OK *ABKW3kFF8J2Jcku9MqSalA==

expected echo-reply: @time=2019-01-07T10:18:07.531Z :keigel2001!~keigel2k1@p... PRIVMSG #testing :TEST

[kylef]

That's an interesting case to consider, the echo-message specification states:

If servers apply any modifications to these messages, they MUST send the final version of the message back to the originating client. (https://ircv3.net/specs/extensions/echo-message-3.2.html)

The wording of MUST is unfortunate here, perhaps it would make sense to try and get echo-message specification adjusted to be a SHOULD or similiar to allow bouncers to not provide the final version of the message in some cases such as if it is encrypted and won't make sense to to the client.