simple-proxy-agent icon indicating copy to clipboard operation
simple-proxy-agent copied to clipboard

wrong socks5h handling

Open wenq1 opened this issue 3 years ago • 1 comments

    let lookup = false;
    switch (this.proxy.protocol) {
      case 'socks4:':
      case 'socks5h:':      // this line is wrong,  should be 'socks5:' instead
        lookup = true;
        break;
    }

See https://github.com/urllib3/urllib3/issues/1035, Quote: In a proxy string, socks5h:// and socks4a:// mean that the hostname is resolved by the SOCKS server, not the client

wenq1 avatar Jan 30 '22 14:01 wenq1

Since you have already changed code, can you do a release?

wenq1 avatar May 06 '22 08:05 wenq1