milvus-helm
milvus-helm copied to clipboard
zilliztech
add namespace metadata
What this PR does / why we need it:
metadata.namespace is missing in some templates.
this is needed for when helm is used purely as a templating tool, since helm template does not add the namespace https://github.com/helm/helm/issues/3553
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
- [ ] Chart Version bumped
- [ ] Variables are documented in the README.md
- [ ] Title of the PR starts with chart name (e.g.
[mychartname]) - [ ] PR only contains changes for one chart
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mchtech
To complete the pull request process, please assign zwd1208 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwd1208 in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @mchtech! It looks like this is your first PR to zilliztech/milvus-helm 🎉
Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.
Hi @mchtech, sry for the delay. Please also bump the version before we could merge it.
branch synced.
@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: haorenfsa, mchtech
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [haorenfsa]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mchtech, sry I missed last version. Please bump the version again. Thank you very much for your patience!
branch synced.