knowhere
knowhere copied to clipboard
Add index feature manager & static config check
issue: #795
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: foxspy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [foxspy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/hold
@foxspy 🔍 Important: PR Classification Needed!
For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
- If you're fixing a bug, label it as kind/bug.
- For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
- Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
- Adjusting APIs or changing functionality? Go with kind/feature.
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #
Thanks for your efforts and contribution to the community!.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.64%. Comparing base (
3c46f4c) to head (9e1257e). Report is 218 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #796 +/- ##
=========================================
+ Coverage 0 79.64% +79.64%
=========================================
Files 0 80 +80
Lines 0 6259 +6259
=========================================
+ Hits 0 4985 +4985
- Misses 0 1274 +1274
@foxspy is it good to review this PR?
/hold wait all tests (include milvus) pass
@foxspy is it good to review this PR?
Thanks, please help with the review. The code won’t change much, but this commit contains a lot of mixed content. I plan to break it into several commits.
split this pr into #887 and #888