knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

Add index feature manager & static config check

Open foxspy opened this issue 1 year ago • 7 comments

issue: #795

foxspy avatar Aug 28 '24 12:08 foxspy

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Aug 28 '24 12:08 sre-ci-robot

/hold

foxspy avatar Aug 28 '24 12:08 foxspy

@foxspy 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

mergify[bot] avatar Aug 28 '24 12:08 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.64%. Comparing base (3c46f4c) to head (9e1257e). Report is 218 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #796       +/-   ##
=========================================
+ Coverage      0   79.64%   +79.64%     
=========================================
  Files         0       80       +80     
  Lines         0     6259     +6259     
=========================================
+ Hits          0     4985     +4985     
- Misses        0     1274     +1274     

see 80 files with indirect coverage changes

codecov[bot] avatar Aug 28 '24 13:08 codecov[bot]

@foxspy is it good to review this PR?

alexanderguzhva avatar Sep 06 '24 15:09 alexanderguzhva

/hold wait all tests (include milvus) pass

foxspy avatar Oct 10 '24 13:10 foxspy

@foxspy is it good to review this PR?

Thanks, please help with the review. The code won’t change much, but this commit contains a lot of mixed content. I plan to break it into several commits.

foxspy avatar Oct 10 '24 13:10 foxspy

split this pr into #887 and #888

foxspy avatar Oct 14 '24 08:10 foxspy