knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

Show illegal vector value in diskann

Open cydrain opened this issue 1 year ago • 2 comments

Issue: https://github.com/milvus-io/milvus/issues/35594

cydrain avatar Aug 22 '24 09:08 cydrain

@cydrain 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

mergify[bot] avatar Aug 22 '24 09:08 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 61.62%. Comparing base (3c46f4c) to head (1bb0c5a). Report is 153 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #773       +/-   ##
=========================================
+ Coverage      0   61.62%   +61.62%     
=========================================
  Files         0       84       +84     
  Lines         0     6153     +6153     
=========================================
+ Hits          0     3792     +3792     
- Misses        0     2361     +2361     

see 84 files with indirect coverage changes

codecov[bot] avatar Aug 22 '24 10:08 codecov[bot]

/lgtm

alexanderguzhva avatar Aug 23 '24 13:08 alexanderguzhva

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cydrain, liliu-z

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [cydrain,liliu-z]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Aug 26 '24 10:08 sre-ci-robot

/lgtm

alexanderguzhva avatar Aug 26 '24 13:08 alexanderguzhva

/kind improvement

cydrain avatar Aug 27 '24 04:08 cydrain