knowhere
knowhere copied to clipboard
ivf_sq support iterator
issue: https://github.com/zilliztech/knowhere/issues/771
@cqy123456 🔍 Important: PR Classification Needed!
For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
- If you're fixing a bug, label it as kind/bug.
- For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
- Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
- Adjusting APIs or changing functionality? Go with kind/feature.
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #
Thanks for your efforts and contribution to the community!.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 70.03%. Comparing base (
3c46f4c) to head (02a6f72). Report is 147 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #772 +/- ##
=========================================
+ Coverage 0 70.03% +70.03%
=========================================
Files 0 74 +74
Lines 0 5419 +5419
=========================================
+ Hits 0 3795 +3795
- Misses 0 1624 +1624
/hold would it be possible to NOT to apply a formatting to Faiss files, because it may significantly complicate merges from the Faiss baseline into our code? Besides, it is much harder to detect the changes in this PR. Changes from
replace_invlists(new ConcurrentArrayInvertedLists(nlist, code_size, ssize, is_cosine), true);
into
replace_invlists(
new ConcurrentArrayInvertedLists(
nlist, code_size, ssize, is_cosine),
true);
are meaningless.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cqy123456, liliu-z
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [cqy123456,liliu-z]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Don't forget to add tags and unhold
/lgtm
/unhold