knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

diskann for pr [WIP]

Open xxxlzhxxx opened this issue 1 year ago • 4 comments

This is the disk-ann iterator, it can be compile. The basic structure of the algorithm is correct. However, tests need to be completed.

xxxlzhxxx avatar Jul 24 '24 02:07 xxxlzhxxx

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xxxlzhxxx To complete the pull request process, please assign foxspy after the PR has been reviewed. You can assign the PR to them by writing /assign @foxspy in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot avatar Jul 24 '24 02:07 sre-ci-robot

Welcome @xxxlzhxxx! It looks like this is your first PR to zilliztech/knowhere 🎉

sre-ci-robot avatar Jul 24 '24 02:07 sre-ci-robot

@xxxlzhxxx 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

mergify[bot] avatar Jul 24 '24 02:07 mergify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.78%. Comparing base (3c46f4c) to head (cce3a43). Report is 215 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #725       +/-   ##
=========================================
+ Coverage      0   71.78%   +71.78%     
=========================================
  Files         0       69       +69     
  Lines         0     4905     +4905     
=========================================
+ Hits          0     3521     +3521     
- Misses        0     1384     +1384     

see 69 files with indirect coverage changes

codecov[bot] avatar Jul 24 '24 13:07 codecov[bot]