knowhere
knowhere copied to clipboard
diskann for pr [WIP]
This is the disk-ann iterator, it can be compile. The basic structure of the algorithm is correct. However, tests need to be completed.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: xxxlzhxxx
To complete the pull request process, please assign foxspy after the PR has been reviewed.
You can assign the PR to them by writing /assign @foxspy in a comment when ready.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @xxxlzhxxx! It looks like this is your first PR to zilliztech/knowhere 🎉
@xxxlzhxxx 🔍 Important: PR Classification Needed!
For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
- If you're fixing a bug, label it as kind/bug.
- For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
- Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
- Adjusting APIs or changing functionality? Go with kind/feature.
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #
Thanks for your efforts and contribution to the community!.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 71.78%. Comparing base (
3c46f4c) to head (cce3a43). Report is 215 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #725 +/- ##
=========================================
+ Coverage 0 71.78% +71.78%
=========================================
Files 0 69 +69
Lines 0 4905 +4905
=========================================
+ Hits 0 3521 +3521
- Misses 0 1384 +1384