knowhere icon indicating copy to clipboard operation
knowhere copied to clipboard

[Question] Why #1346 only brings the patch version change ?

Open cydrain opened this issue 1 month ago • 2 comments

PR #1346 adds the parameter “milvus::OpContext*” to every public interface, which is a breaking change. Per semantic versioning, this requires bumping knowhere’s major version. Why it increments only knowhere's patch version number ?

cydrain avatar Oct 25 '25 01:10 cydrain

This change is only intended to track some information along the query path and does not involve significant adjustments to the code structure. As shown in the PR, the code basically just adds an extra parameter to the corresponding function.

In general, major version changes of Knowhere follow the Milvus release cycle, so the Knowhere major version was not upgraded in this case.

foxspy avatar Oct 28 '25 09:10 foxspy

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

github-actions[bot] avatar Nov 28 '25 02:11 github-actions[bot]