zha-device-handlers icon indicating copy to clipboard operation
zha-device-handlers copied to clipboard

[Device Support Request] for Lidl Christmas led string HG0646

Open erkr opened this issue 3 years ago • 25 comments

Please add a quirk to support the melinera HG06467 Christmas light strings sold by the LIDL.

The strings are supported by Z2M: https://www.zigbee2mqtt.io/devices/HG06467.html

And there exists an issue for this that became stale. That issue contains all information wrt these Christmas led strings: https://github.com/zigpy/zha-device-handlers/issues/604

Best Eric

erkr avatar Nov 17 '22 19:11 erkr

Hola @javicalle !!

If you have time this device is very wanted for the moment and is one real "tuya hybrid" that is using normal Zigbee commands and some very tuya cooked ones.

In ground is one normal light that have pixel LEDs and the normal lights things is Zigbe commands and the pixel is having some special commands implanted.

I have not baying it then is was little over my budged but many users have doing it.

If you have time and can taking one look may user wold getting one nice Christmases if you can cocking one quirk for it.

Mvh Mattias

MattWestb avatar Nov 19 '22 09:11 MattWestb

Is there anything we can do to help with this effort? I have this product as well and it would be awesome to control the effects via ZHA 🎄

rkruisselbrink avatar Dec 13 '22 09:12 rkruisselbrink

I can help to test with local quirks. Wife is not happy😱

erkr avatar Dec 14 '22 12:12 erkr

A lot of time left before Christmas 😉

erkr avatar Jan 01 '23 10:01 erkr

@TheJulianJES We was trying getting one of this to our US friends for2 years ago but we was not getting any that was willing baying and shipping it from Europe. If you is getting one or some else in CE is having one and can getting it to you can you taking one look getting one working quirk for it ? I think its one normal RGB light plus extra scenes for searing the pixel LEDs with tuya MCU commands.

MattWestb avatar Jan 13 '23 19:01 MattWestb

For users that having one of this "devices" and need it working next Christmas is the devs needing getting hand of one for testing and doing the coding.

In CE we have great quirk devs in Germany and in Spain and probably more if we asking little more around.

Pleas helping getting the beloved device working by sharing hardware for some time and getting it working with our systems.

Thanks in advance !!!

MattWestb avatar Jan 13 '23 19:01 MattWestb

I am from Germany and have this Device, i would be willing to send it to any quirk dev, preferable in Germany, for some time.

xanibale avatar Jan 18 '23 11:01 xanibale

Great @xanibale I pinging @TheJulianJES hi is located in Ger and have the knowledge and if need hi is getting help from our US or Spanish devs.

I hoping for the next Christmas shall being white with much colors in the (dev)tree !!!

MattWestb avatar Jan 18 '23 11:01 MattWestb

At the moment, I don't have enough time to work on a (Tuya) device with a given time limit.

It'll also be hard to implement the effects properly and ZHA (HA Core) would probably also need to be modified for this.

TheJulianJES avatar Jan 19 '23 16:01 TheJulianJES

If i would get it back until next Christmas, then there should be no problem, as it is now not usable for me anyway. It would be very nice to use the colour/ white capabilities of the device. If that would make things easier.

xanibale avatar Jan 20 '23 10:01 xanibale

Yes, first fixing normal colour and brightness control would be a great step. Now the colours change when the brightness is adjusted.

erkr avatar Jan 21 '23 22:01 erkr

Christmas seem still far away, but we are 6 months further 🙏

erkr avatar Jul 08 '23 09:07 erkr

I was also thinking about this. Is there some guide or docs on how we can test/debug this? I'm willing to give it a shot and spent some time on this, but i have no idea where to start 😅

rkruisselbrink avatar Jul 26 '23 13:07 rkruisselbrink

I also own the those Christmas lights and I'am willing to invest some time to get them integrated until Christmas (Or even better some weeks before ;-) )

Is there already a kind of draft where I can try to contribute?

d3nnis0 avatar Oct 12 '23 10:10 d3nnis0

Is there already a kind of draft where I can try to contribute?

Not that i know of. Any idea how to approach this?

rkruisselbrink avatar Oct 24 '23 06:10 rkruisselbrink

I noticed that the Christmas lights where added to the Deconz integration: https://github.com/Kane610/deconz/issues/198

I hope some expert knows how to translate the information that seems to be available there into a handler for ZHA

erkr avatar Oct 30 '23 10:10 erkr

I noticed that the Christmas lights where added to the Deconz integration: Kane610/deconz#198

I hope some expert knows how to translate the information that seems to be available there into a handler for ZHA

FYI, for development reference, the developer of the deCONZ integration for Home Assistant also added "effects" and "colors" support for HG06467 (Zigbee ID "TS0601") Lidl Silvercrest Christmas light to Home Assistant's deCONZ integration now too:

https://github.com/home-assistant/core/pull/102731 -> https://github.com/home-assistant/core/pull/102731/commits/d58dcd179ec322602afb74ee909bde93fbbdf022

https://github.com/home-assistant/core/pull/105155 -> https://github.com/home-assistant/core/pull/105155/commits/fecdb6c20fd78d45007a483e76920bfbb3a27ed2

https://community.home-assistant.io/t/lidl-melinera-christmas-string-hg06467-lidl-livarno-lux/367

https://community.home-assistant.io/t/update-deconz-integration-to-support-flash-with-color/246904/

PS: For more reference, same "effect" and "color" support for Lidl Malinera "Smart LED String Lights" HG06467 (Zigbee ID "TS0601") was added to zigbee-herdsman-converters for Zigbee2MQTT back in 2020 and these are their pull request and discussions about it:

https://github.com/Koenkk/zigbee-herdsman-converters/pull/1799

https://github.com/Koenkk/zigbee-herdsman-converters/issues/1792

https://zigbee2mqtt.discourse.group/t/lidl-christmas-lights/1788/

https://github.com/Koenkk/zigbee2mqtt/issues/5221

Hedda avatar Dec 08 '23 15:12 Hedda

I tried to hack something together last year this same time (one week before Christmas). My neighbors are still not happy so also I am keen to debug any contributions to this draft.

https://gist.github.com/enyone/e1e0182f41ab9924d33fd24d77765aa6

See that 0xFC: foundation.ZCLCommandDef(... I created to issue effect change command and a handler for that if command_id == 0x00FC: with a static data tuya_payload.data = [0x00, 0x0A, 0x30, 0x31, 0x30, 0x30, 0x40, 0x40, 0x40, 0x40, 0x40, 0x40] to play around.

enyone avatar Dec 12 '23 19:12 enyone

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Jun 09 '24 20:06 github-actions[bot]

I think we want to keep this open. I didn't have (make) time yet to checkout the implementation by @enyone

rkruisselbrink avatar Jun 10 '24 06:06 rkruisselbrink

I tried to hack something together last year this same time (one week before Christmas). My neighbors are still not happy so also I am keen to debug any contributions to this draft.

https://gist.github.com/enyone/e1e0182f41ab9924d33fd24d77765aa6

See that 0xFC: foundation.ZCLCommandDef(... I created to issue effect change command and a handler for that if command_id == 0x00FC: with a static data tuya_payload.data = [0x00, 0x0A, 0x30, 0x31, 0x30, 0x30, 0x40, 0x40, 0x40, 0x40, 0x40, 0x40] to play around.

I don't know if you've looked at this some more, but thanks to this i'm able to choose colors, however the colors i choose don't seem to correspond to the colors i choose (e.g. i choose red in HA, but the light turn yellow). it seems that color temperature is not set correctly. I'm able/willing to help troubleshoot/debug but i have no i idea what i'm looking at in the quirk.. :/ Can you maybe point me in the right direction?

Melantrix avatar Nov 30 '24 12:11 Melantrix

I still have these lights on my yard's bushes.

For now I've beard with that broken XY-mode, where actual string's LED color is not always quite the one one picks at RGB map palette.

This https://gist.github.com/enyone/e1e0182f41ab9924d33fd24d77765aa6 actually brings only (sightly broken) XY-mode available (where you can pick one led color for all string's LED using RGB map palette). Without that quirk only HS-mode is available (using Hue slider and/or buttons) but it does not work at all. For some reason this device reports HS-mode as only supported mode, whereas that quirk forces the modes XY-mode and CT-mode as supported ones. See LidlRGBColorCluster in quirk code.

Why XY-mode is broken, I don't know. I would guess this device uses some non-8-bit (but less) color depth.

Another thing that quirk tries to create support for is effects (flashing multi-color effects Lidl's Android App specifies). I have not found any documentation or similar implementation elsewhere to use as a reference, and fall back to reverse-engineering bytes using Lidl's Android App as a source of those bytes. One example set of bytes is present in that quirk code line 98: tuya_payload.data = [0x00, 0x0A, 0x30, 0x31, 0x30, 0x30, 0x40, 0x40, 0x40, 0x40, 0x40, 0x40]

That array of bytes is send as a payload data to device using TuyaManufCluster.Command with: command_id=TUYA_SET_DATA (0x00) function=TUYA_EFFECT_COMMAND (0x0603)

See LidlEffectCluster in quirk code and more from https://github.com/zigpy/zha-device-handlers/blob/dev/zhaquirks/tuya/init.py#L324

That array of bytes is just an example and more different samples (by reverse-engineering Lidl's Android App sent payloads) needs to be observed to create something working.

enyone avatar Dec 10 '24 18:12 enyone

z2m seems to support the light effects. So someone knowledgeable can reuse that for zha I guess

erkr avatar Dec 10 '24 22:12 erkr

This seems to be broken in ZHA now. Last year it still kind of worked, I could control color. Now only on-off works as expected. The color setting/brightness changes colors randomly.

smoltron avatar Dec 23 '24 10:12 smoltron

Plenty of time left till next Christmas 🤓

erkr avatar Jun 22 '25 16:06 erkr