zha-device-handlers
zha-device-handlers copied to clipboard
zigpy
#940: Add Aqara H1 Wireless Remote Double Rocker Version WRS-R02, variant 3
- With no model info
- endpoint 1 declared as color dimmer (261)
- No input/output declared
Big hack line 304: MODELS_INFO: [(LUMI, "lumi.remote.b28ac1"), (None, None)],
But, how can I do otherwise when I receive manufacturer=None and model=None ...
In the plugin-zigbee, I change into lumi.remote.b28ac1.json logical ids with
"logicalId": "1::18::0" and "logicalId": "2::18::0"
Pull Request Test Coverage Report for Build 3331682582
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 80.68%
| Totals | |
|---|---|
| Change from base Build 3328459775: | 0.0% |
| Covered Lines: | 6072 |
| Relevant Lines: | 7526 |
💛 - Coveralls
Codecov Report
Base: 80.68% // Head: 80.68% // No change to project coverage :thumbsup:
Coverage data is based on head (
a2aadaf) compared to base (dc3f348). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## dev #1676 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 242 242
Lines 7526 7526
=======================================
Hits 6072 6072
Misses 1454 1454
| Impacted Files | Coverage Δ | |
|---|---|---|
| zhaquirks/xiaomi/__init__.py | 83.79% <ø> (ø) |
|
| zhaquirks/xiaomi/aqara/remote_h1.py | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I have had to pair some devices several times because they did not report the manufacturer or model correctly. Have you tried pairing the device again? Make sure to keep your device awake. You can usually do this by briefly pressing the button while the pairing is taking place.
none for these values is from a failed pairing. We will not add that to quirks
Closing for now. The device should be picked up as one of the other variants already. Make sure you're running the somewhat up-to-date firmware on your coordinator (for Aqara manufacturer codes) and try re-pairing the device multiple times while pressing buttons on it.
A pairing with manufacturer=None, model=None, and no clusters reported is a failed or incomplete pairing.
