HTML-CSS-Class-Completion icon indicating copy to clipboard operation
HTML-CSS-Class-Completion copied to clipboard

Allow escaped characters in css selectors

Open canvasplay opened this issue 4 years ago • 8 comments

Fixes autocomplete for css selectors with escaped characters as described here #288. Currently only supporting the following escaped characters: \/, \@, \:

Fixes #288

canvasplay avatar Dec 26 '20 15:12 canvasplay

This doesn't works as expected (or I messed up copying n pasting your code :sleeping:). Now it matches pseudo-classes/elements like .some-class:after and doesn't match classes with escaped characters at all.

dziku86 avatar Mar 11 '21 19:03 dziku86

Hello, sorry for long time inactive. I fixed the error, now it does not parse unwanted pseudo selectors like :hover, :focus, etc.. Many thanks to @AeonFr helping with the regex.

canvasplay avatar Aug 17 '21 10:08 canvasplay

@canvasplay Thank you for working on this!

Would it be possible to add an escape for .? I use a CSS class utility lib that is similar to tailwind, and has classes such as hrem-1\.5 for "height of 1.5rem". These classes are not detected by the extension.

brochington avatar Sep 04 '21 18:09 brochington

Hi @brochington, if you don't mind, let's see first if @dziku86 want to merge this ;)

canvasplay avatar Sep 13 '21 06:09 canvasplay

Any news on accepting this @dziku86?

canvasplay avatar Nov 24 '21 09:11 canvasplay

Any news on accepting this @dziku86?

Alright! What the thumbs up really means? Are there any inconvenience on merging this PR? I think this is a good addition to the plugin and several people will benefit from it.

canvasplay avatar Jan 21 '22 22:01 canvasplay

Any news on accepting this @dziku86?

Alright! What the thumbs up really means? Are there any inconvenience on merging this PR? I think this is a good addition to the plugin and several people will benefit from it.

@canvasplay I don't have write access to merge pull requests :confused:.

dziku86 avatar Jan 24 '22 18:01 dziku86

so @zignd, any chances to merge this? some people are interested on this addition. Thanks in advance for your time!

canvasplay avatar Jan 25 '22 20:01 canvasplay