Alexandre Garnier
Alexandre Garnier
@dajac KIP is now accepted. Next step is to validate this PR.
@dajac: code updated to reflect KIP, and also rebased.
@dajac: thanks for your review, I did most of the proposed fixes.
Thanks @C0urante for the feedback. No problem for the issue in the first place, I guess not many people were impacted by this as nobody raised this issue. I'm more...
@C0urante In the meantime I added a test by copying the `LogCaptureAppender` from #10528. Not the best with the while loop to wait for the log to be created in...
Thanks for this thorough feedback @C0urante! Fixed the `checkstyle/import-control.xml`, did revert too much after a lot of testing and importing new packages. About the `DefaultHandler`, looks like it's currently not...
@C0urante: what about using the existing scala implementation `kafka.utils.LogCaptureAppender`? I added a commit to try it and it works. May add some methods in scala implementation for easier use in...
@C0urante No problem. Your scenario is fine by me.
Superseded by #220
No problem, thanks for the review.