tao
tao copied to clipboard
zesterer
Cargo fmt
Hi!
As briefly discussed on mastodon, here goes my first patchset.
This PR does only run cargo-fmt on the codebase, as a first step. A later PR will introduce cargo-fmt checking in github actions.
Deploy Preview for thriving-beignet-855860 ready!
| Name | Link |
|---|---|
| Latest commit | 77d74f6432690c3a0cbc640bece41bfa7ec6aa32 |
| Latest deploy log | https://app.netlify.com/sites/thriving-beignet-855860/deploys/640ae114d39a0d0008506ab7 |
| Deploy Preview | https://deploy-preview-48--thriving-beignet-855860.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
Unfortunately I'm not sure I can accept this PR at the moment. rustfmt has done some pretty painful things to some of the code here, particularly in and around the type solver. Perhaps in time when things are refactored and made cleaner a format pass would be a bit less painful to deal with, but for now there's too much that becomes actively harder to understand because of it :\
As a random example of something that goes from being neat and easy to reason about to simply being opaque visual noise:
Perhaps in time when things are refactored and made cleaner a format pass would be a bit less painful to deal with, but for now there's too much that becomes actively harder to understand because of it :\
I see where you're coming from... but wouldn't the other way round also be a sensible way? Format the codebase, which easily shows the bits that are refactor-worthy (like the bit you from your screenshot) and then refactor them? :laughing:
Refactoring the type checker would be... A mammoth task. I absolutely want to do it at some point, but not before I figure out a formalisation for things like effect type inference.