jszmq icon indicating copy to clipboard operation
jszmq copied to clipboard

Chat Example Project

Open cryptoquick opened this issue 5 years ago • 5 comments
trafficstars

This PR is a small example project of a chat app written with jszmq. I decided to do this work first before the async/await work in #4 because this work will help a great deal with the conversion.

Tasks

  • [x] Chat Example

cryptoquick avatar Jul 29 '20 10:07 cryptoquick

So, Cypress has a limitation that prevents it from being used to test across multiple windows. It recommends stubbing that behavior instead, which isn't really a great end to end test. It makes a lot of sense to do that, but not with this example project. I'm going to reduce the scope of this pull request for now.

The rest of the work is finished, however, so that could prove useful to others seeking to use the library in its current state, and it'll also be very useful for testing when moving towards an async/await API.

cryptoquick avatar Aug 01 '20 21:08 cryptoquick

One more thing... I just realized, I forgot to exclude the example project from the jszmq example config when tests are compiled. I had split them up into two separate configs as an optimization step. At this point I forget why... But I'll add the example node_modules to the clear:all script, too.

cryptoquick avatar Aug 01 '20 21:08 cryptoquick

That should be RFR now. :+1:

cryptoquick avatar Aug 01 '20 21:08 cryptoquick

I think #17 should be merged before this one.

The package version on this branch is still 0.1.3, but I think it would be wise to bump the semver minor on this one, to version 0.2.0.

cryptoquick avatar Aug 03 '20 23:08 cryptoquick

@somdoron Can you review #17 and #16 sometime? It's been a little while, lol!

cryptoquick avatar Dec 24 '20 09:12 cryptoquick