jeromq icon indicating copy to clipboard operation
jeromq copied to clipboard

Sockets javadoc should talk about ordinal is also type

Open fbacchella opened this issue 7 years ago • 2 comments

When reading the source from zmq.socket.Sockets, it make thing that ordinal get the same value that the type, so zmq.socket.Sockets.PUSH.ordinal() == zmq.ZMQ.PUSH and the same for all values.

One needs to read the source to find that and understand why there is no zmq.socket.Sockets.type().

fbacchella avatar Apr 23 '18 14:04 fbacchella

I think zmq package is internal and as I see none of the zmq classes has proper javadoc because of this fact that it's not a good idea to use these internal classes directly. It's a better idea to use classes in org.zmq. I'm not sure about this, Maybe a mentor can confirm this.

isahekmat avatar Jun 23 '18 07:06 isahekmat

@esahekmat I can confirm this. org.zeromq is the higher-level API recommended for consumption, whereas zmq is the underlying lower-level implementation, which I don't think should ever be used directly.

daveyarwood avatar Oct 28 '18 02:10 daveyarwood