jeromq
jeromq copied to clipboard
Tell the user the address that failed to connect.
Current:
Caused by: org.zeromq.ZMQException: blah-blah : Address not available
Yes, but which address??
New error (I think?):
Caused by: org.zeromq.ZMQException: failed connecting to 0.0.0.0:5678: blah-blah : Address not available
I'm new-ish to github, and have no clue if builds/tests are running on this PR. Sorry if I should have waited for them before sending out for review.
I think you should use the name variable instead of addrStr
I think you should use the
namevariable instead ofaddrStr
Sorry, could you share more? What is name and what would it look like in comparison to addrStr?
Just look at the argument of the function: https://github.com/zeromq/jeromq/blob/c9132d7bb7958118f955e68181f16aa589276b87/jeromq-core/src/main/java/zmq/io/net/tcp/TcpAddress.java#L100