filemq icon indicating copy to clipboard operation
filemq copied to clipboard

Latest commit doesn't build with msvc

Open keent opened this issue 9 years ago • 15 comments

Let me know how to fix this so I can help and also create a release version - last one was 4 years ago

keent avatar Jan 20 '16 08:01 keent

I'll rebuild the packaging, zproject is now up to speed on Windows and other systems.

On Wed, Jan 20, 2016 at 9:48 AM, Gran Ville Lintao <[email protected]

wrote:

Let me know how to fix this so I can help and also create a release version - last one was 4 years ago

— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/67.

hintjens avatar Jan 20 '16 10:01 hintjens

@hintjens - thanks. Im checking out zproject and it seems it can only be installed and used on linux?

keent avatar Jan 20 '16 10:01 keent

OK, all done here: https://github.com/zeromq/filemq/pull/68

Just did about a year's worth of packaging work in a few minutes.

On Wed, Jan 20, 2016 at 11:46 AM, Pieter Hintjens [email protected] wrote:

I'll rebuild the packaging, zproject is now up to speed on Windows and other systems.

On Wed, Jan 20, 2016 at 9:48 AM, Gran Ville Lintao < [email protected]> wrote:

Let me know how to fix this so I can help and also create a release version - last one was 4 years ago

— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/67.

hintjens avatar Jan 20 '16 10:01 hintjens

Ah, it will work on Windows and OS/X from the command line. You need to install gsl.

The text in scalablec.org may help (though it's unfinished).

On Wed, Jan 20, 2016 at 11:51 AM, Gran Ville Lintao < [email protected]> wrote:

@hintjens https://github.com/hintjens - thanks. Im checking out zproject and it seems it can only be installed and used on linux?

— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/67#issuecomment-173169857.

hintjens avatar Jan 20 '16 10:01 hintjens

@hintjens Awesome. Thanks. Can you please give me commit access to filemq so I can merge it now?

keent avatar Jan 20 '16 10:01 keent

OK, you're maintainer now. Enjoy :)

hintjens avatar Jan 20 '16 11:01 hintjens

@hintjens great, thanks. It's still not building completely - filemq has a different Project Configuration in msvc compared to its dependencies - czmq, libsodium, zmq - which are all building fine under "DynDebug" project config in win32.

I can fix this manually but what's the proper way to fix this?

keent avatar Jan 20 '16 12:01 keent

more precisely, the czmq lib isn't built as "libczmq.lib". All the dependencies and filemq use the pattern "lib[librarynamehere].lib" so filemq refers to libczmq.lib, but czmq is built only as czmq.lib

keent avatar Jan 20 '16 12:01 keent

Best way to fix this is to patch the project files by hand, until it works, and then make a pull request. I'll then backport those fixes to zproject.

On Wed, Jan 20, 2016 at 1:56 PM, Gran Ville Lintao <[email protected]

wrote:

more precisely, the czmq lib isn't built as "libczmq.lib". All the dependencies and filemq use the pattern "lib[librarynamehere].lib" so filemq refers to libczmq.lib, but czmq is built only as czmq.lib

— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/67#issuecomment-173195994.

hintjens avatar Jan 20 '16 13:01 hintjens

@hintjens Here's for the libfilemq project in msvc - #69 - Im still working on the client and server

keent avatar Jan 21 '16 12:01 keent

I don't see where the CZMQ build is producing czmq.lib/dll; the project is called libczmq. Could you double-check you're using the latest CZMQ master and msvc builds?

Rather than change filemq to use czmq.lib we should be building libczmq.lib.

On Thu, Jan 21, 2016 at 1:09 PM, Gran Ville Lintao <[email protected]

wrote:

@hintjens https://github.com/hintjens Here's for the libfilemq project in msvc - #69 https://github.com/zeromq/filemq/pull/69 - Im still working on the client and server

— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/67#issuecomment-173552617.

hintjens avatar Jan 21 '16 15:01 hintjens

I wasn't using the latest CZMQ master - was using the latest tagged release because it wasn't building in msvc as well.

keent avatar Jan 21 '16 16:01 keent

OK, that explains it. We have to be using master. I did a sweep to getting libzmq, czmq, zyre, etc. working on Windows. You need master of each. The exception is libsodium: you do need the last tagged release. If you can't build libzmq, give a shout since that must work.

hintjens avatar Jan 21 '16 17:01 hintjens

Everything's building now - I added this to czmq - I know this isn't the right way but as you said for backporting - https://github.com/zeromq/czmq/pull/1325

keent avatar Jan 26 '16 09:01 keent

And this on FileMQ - https://github.com/zeromq/filemq/pull/71

keent avatar Jan 26 '16 09:01 keent