filemq
filemq copied to clipboard
zeromq
FileMQ uses deprecated CZMQ API's
There are a lot of references to deprecated czmq API's in FileMQ. Not sure if it will be acceptable, but I am working on fixing this for the c code. I do not have any expertise for Java.
Oh, great!
If you really want to give FileMQ an overhaul, take a look at zproto for generating the client and server. :)
-Pieter
On Thu, Nov 13, 2014 at 11:24 PM, Dan Riegsecker [email protected] wrote:
There are a lot of references to deprecated czmq API's in FileMQ. Not sure if it will be acceptable, but I am working on fixing this for the c code. I do not have any expertise for Java.
— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/58.
I will look at zproto and give this my best shot. I see value in FileMQ for a project that I am working on.
In fact, if you learn zproto you can rebuild FileMQ or similar stacks fairly rapidly. FileMQ has the flaw that you can't upload a file over the protocol, only receive them. The protocol is a good example of file transfer, though.
On Fri, Nov 14, 2014 at 4:14 PM, Dan Riegsecker [email protected] wrote:
I will look at zproto and give this my best shot. I see value in FileMQ for a project that I am working on.
— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/58#issuecomment-63077755.
I wasn't sure about the best way to make major updates to the existing filemq project, so I created a second project named filemq2 that can be found at https://github.com/danriegsecker/filemq2. I built this based on the RFC 35 (http://rfc.zeromq.org/spec:35) without any modifications. You will find some things that aren't yet implemented. I built this updated project using zproject and zproto. I have used this project, thus far, as a learning process for zproto and zproject. Let me know if any of this is useful to the work that was already done on the original filemq.
The original filemq can be scrapped, really. It was the basis for zproto. If your code is clean and matches our style guidelines, then why not just push it to filemq and overwrite what there is... :-)
On Tue, Dec 9, 2014 at 5:47 PM, Dan Riegsecker [email protected] wrote:
I wasn't sure about the best way to make major updates to the existing filemq project, so I created at filemq2 project that can be found at https://github.com/danriegsecker/filemq2. I built this based on the RFC 35 (http://rfc.zeromq.org/spec:35) without any modifications. You will find a somethings that aren't yet implemented. I built this updated project using zproject and zproto. I have used this project, thus far, as a learning process for zproto and zproject. Let me know if any of this is useful to the work that was already done on the original filemq.
— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/58#issuecomment-66314348.
Would everyone prefer to browse the code where it is or would you like me to just move it into filemq and create a pull request, where you could decide from there? I am up for whatever the community prefers. I believe I tried to follow all the community guidelines, but I know that I am not perfect. This project does currently have a lot of debug printing, which may not be appreciated.
As a general rule it's better to merge first and improve later. On Dec 9, 2014 6:04 PM, "Dan Riegsecker" [email protected] wrote:
Would everyone prefer to browse the code where it is or would you like me to just move it into filemq and create a pull request, where you could decide from there? I am up for whatever the community prefers. I believe I tried to follow all the community guidelines, but I know that I am not perfect. This project does currently have a lot of debug printing, which may not be appreciated.
— Reply to this email directly or view it on GitHub https://github.com/zeromq/filemq/issues/58#issuecomment-66317454.
Just today I built Dan Riegsecker's version with minor fixes now at https://github.com/danriegsecker/filemq2/pull/1/commits/fe75348f35dde4017f05d63225a8a0266b5d4fed or directly at https://github.com/johnaman/filemq2 -- checkout branch "debian_fix"
I believe this issue should be closed now that pull request #59 was merged. I had to checkout both sources and diff them to see the differences and there isn't much anymore; and the differences there are seem to be more recent with filemq vs filemq2
