go-zero icon indicating copy to clipboard operation
go-zero copied to clipboard

chore: bump to use go1.23

Open chenrui333 opened this issue 1 year ago • 10 comments

update go.mod and go.sum for https://github.com/Homebrew/homebrew-core/pull/178656

chenrui333 avatar Jul 27 '24 13:07 chenrui333

Thanks for your PR!

Would you please let me know why we need to upgrade go to 1.21?

kevwan avatar Jul 27 '24 13:07 kevwan

Would you please let me know why we need to upgrade go to 1.21?

I just run the go mod tidy with go 1.22.5 and it got populated automatically. (homebrew side also built with go 1.22.5 as well)

chenrui333 avatar Jul 27 '24 22:07 chenrui333

from golang team perspective, they only maintains the most two recent major release lines. 1.21 and 1.22 (see https://endoflife.date/go)

chenrui333 avatar Jul 27 '24 22:07 chenrui333

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.54%. Comparing base (8690859) to head (19c5fc3). Report is 133 commits behind head on master.

Additional details and impacted files

see 262 files with indirect coverage changes

codecov[bot] avatar Jul 28 '24 09:07 codecov[bot]

Homebrew also works on go 1.20.

https://github.com/Homebrew/homebrew-core/pull/178656 is already merged.

But please let us discuss on upgrading go version with goctl. Thanks!

kevwan avatar Jul 28 '24 09:07 kevwan

But please let us discuss on upgrading go version with goctl. Thanks!

it is just unblocking the homebrew build (packaging build does not necessarily the same as the project build, which they should be the same for the most cases), we can totally accommodate the desired changes in here for the next release build

chenrui333 avatar Jul 28 '24 14:07 chenrui333

goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well.

kevwan avatar Jul 29 '24 01:07 kevwan

goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well.

yeah, I can update both to go1.21 (I dont see why not)

chenrui333 avatar Jul 30 '24 16:07 chenrui333

actually move the workflow syntax change into a separate PR, #4286

chenrui333 avatar Jul 30 '24 16:07 chenrui333

actually move the workflow syntax change into a separate PR, #4286

Thanks! It's already merged.

kevwan avatar Aug 03 '24 06:08 kevwan