go-zero
go-zero copied to clipboard
chore: bump to use go1.23
update go.mod and go.sum for https://github.com/Homebrew/homebrew-core/pull/178656
Thanks for your PR!
Would you please let me know why we need to upgrade go to 1.21?
Would you please let me know why we need to upgrade go to 1.21?
I just run the go mod tidy with go 1.22.5 and it got populated automatically. (homebrew side also built with go 1.22.5 as well)
from golang team perspective, they only maintains the most two recent major release lines. 1.21 and 1.22 (see https://endoflife.date/go)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.54%. Comparing base (
8690859) to head (19c5fc3). Report is 133 commits behind head on master.
Additional details and impacted files
Homebrew also works on go 1.20.
https://github.com/Homebrew/homebrew-core/pull/178656 is already merged.
But please let us discuss on upgrading go version with goctl. Thanks!
But please let us discuss on upgrading go version with goctl. Thanks!
it is just unblocking the homebrew build (packaging build does not necessarily the same as the project build, which they should be the same for the most cases), we can totally accommodate the desired changes in here for the next release build
goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well.
goctl better to use the same go version as go-zero, because I think if go-zero work with a go version, goctl should do as well.
yeah, I can update both to go1.21 (I dont see why not)
actually move the workflow syntax change into a separate PR, #4286
actually move the workflow syntax change into a separate PR, #4286
Thanks! It's already merged.