cppkiteconnect icon indicating copy to clipboard operation
cppkiteconnect copied to clipboard

Published 20 hours ago • verified publisher icon zerodha

feat: v2

Open bhumitattarde opened this issue 3 years ago • 3 comments

bhumitattarde avatar Oct 10 '22 18:10 bhumitattarde

@bhumitattarde, would it be possible to share a few steps to review this?

rhnvrm avatar Oct 11 '22 10:10 rhnvrm

@bhumitattarde, would it be possible to share a few steps to review this?

Skip the Files Changed tab and browse the branch directly. Focus on the kitepp directory. You've already looked at responses/* files so those can be skipped. Start with kite.hpp, it has interface of the kite (REST) class. The implementations can be found in the kite/ directory. ticker/ws.hpp has interface for the websocket api and the implementation is in internal.hpp. After that, the only major files are exceptions.hpp and utils.hpp.

tests has similar structure.

bhumitattarde avatar Oct 12 '22 06:10 bhumitattarde

Thanks @bhumitattarde, gave a quick glance; will do a deeper dive over the weekend.

@ranjanrak @ajinasokan possible to review as well and also run the examples?

https://github.com/zerodha/cppkiteconnect/tree/v2

rhnvrm avatar Oct 13 '22 08:10 rhnvrm

Removing the previous comment. Have an updated v2 fork with latest libraries, bug fixes and vcpkg manifest integration - details here https://github.com/zerodha/cppkiteconnect/issues/54

sukesh-ak avatar Jan 02 '23 06:01 sukesh-ak

@rhnvrm @ajinasokan I don't have any more changes to make. Can we merge this if there's nothing to add?

bhumitattarde avatar Jan 12 '23 06:01 bhumitattarde