cppkiteconnect icon indicating copy to clipboard operation
cppkiteconnect copied to clipboard

Published 20 hours ago • verified publisher icon zerodha

Remove websocket_ticks binary

Open rhnvrm opened this issue 4 years ago • 2 comments

We should not check-in this binary and figure out a better way to mock websocket.

Ref: #30

rhnvrm avatar Jul 04 '21 15:07 rhnvrm

  1. What are the disadvantages of current approach?
  2. How would you like to go about this?

bhumitattarde avatar Jul 04 '21 15:07 bhumitattarde

I explored this further today and ported one of our internal tests to gokiteconnect.

https://github.com/zerodha/gokiteconnect/pull/55

This is based on packets added to mock_responses which I added that use the latest snapshots:

https://github.com/zerodha/kiteconnect-mocks/commit/fd12de13ffa49ea175f62a83a17cf27450c518bf

It uses base64 encoded packets of "full" and "quote" mode packets.

I think we can do something similar in cppkiteconnect and other libs as well.

rhnvrm avatar Jul 05 '21 06:07 rhnvrm