ice icon indicating copy to clipboard operation
ice copied to clipboard

Ignore Ice.Plugin.IceSSL for compatibility with 3.7

Open pepone opened this issue 1 year ago • 2 comments

What will happen if the user keep this property in his config file? Do we have any validation of plug-in names with an Ice prefix?

Originally posted by @bernardnormier in https://github.com/zeroc-ice/ice/pull/2388#pullrequestreview-2154678837

We should review, but I think we should probably ignore the property.

pepone avatar Jul 02 '24 21:07 pepone

There are already lots of property changes: we're removing deprecated properties, old irrelevant properties, etc. I don't think we should specially ignore a single property just for version sharing.

IMO if you use Ice.Plugin.IceSSL with 3.8 you should get a warning, assuming we have check for Ice.Plugin.XXX

externl avatar Jul 03 '24 12:07 externl

My understanding is IceSSL remains a plugin in Ice 3.8, just like TCP is a plugin, UDP is a plugin etc.

https://github.com/zeroc-ice/ice/blob/d6e44874ca8d6892f96a6b7b07fcba08b7bb47e2/cpp/include/Ice/RegisterPlugins.h#L48

So presumably Ice.Plugin.IceSSL=1 should be valid, just like Ice.Plugin.IceUDP=1 is valid.

bernardnormier avatar Jul 15 '24 18:07 bernardnormier

I verified it works fine in C++.

bernardnormier avatar Sep 26 '24 19:09 bernardnormier