zenml icon indicating copy to clipboard operation
zenml copied to clipboard

Add the ability to use Github repos that contain symlinks.

Open aiakide opened this issue 1 year ago β€’ 2 comments

Describe changes

I had noticed that my GitHub repo was having problems encoding files. Bildschirmfoto 2024-09-10 um 18 22 10

As it turned out, the GitHub API also provides symlinks as files when they are checked into the repo. These files have no encoding information (no decoded_content).

I added the functionality that symlinks present in a GitHub repo are also created in the local copy of the repo. The symlink information is collected first and only after all files have been downloaded from the GitHub API, the symlinks are created.

It seems that this error only occurs with the GitHub API. The response of the GitLab API also contains content and encoding information for symlinks.

{
  "file_name": "latest",
  "file_path": "logs/scheduler/latest",
  "size": 10,
  "encoding": "base64",
  "content_sha256": "c1e9c1c135c34aa0eace8cbc57559af9a250f4fb93882b4bb9bf59c8dd73dfea",
  "ref": "main",
  "blob_id": "2d1f1c07a2151a06900dc48cf22c7d5072057cdb",
  "commit_id": "c41843c07b1499bfea65d2a417d47a472873247d",
  "last_commit_id": "e05ba60199ec18f43691952d4aff4b5da6dfc7f4",
  "execute_filemode": false,
  "content": "MjAyNC0wOS0wOQ=="
}

Pre-requisites

Please ensure you have done the following:

  • [x] I have read the CONTRIBUTING.md document.
  • [ ] If my change requires a change to docs, I have updated the documentation accordingly.
  • [x] I have added tests to cover my changes.
  • [x] I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • [ ] If my changes require changes to the dashboard, these changes are communicated/requested.

Types of changes

  • [X] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Other (add details above)

aiakide avatar Sep 16 '24 12:09 aiakide

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 16 '24 12:09 CLAassistant

[!IMPORTANT]

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❀️ Share
πŸͺ§ Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 16 '24 12:09 coderabbitai[bot]

Hey @aiakide, are you still planning on getting this PR merged?

schustmi avatar Nov 26 '24 09:11 schustmi

Hey @aiakide, are you still planning on getting this PR merged?

Hi @schustmi πŸ‘‹ , Yes, I would still make the changes available in a PR. Then I'll leave it up to you to decide whether the changes should be integrated. The PR really only covers a small edge case.

Sorry for not getting in touch for so long. Unfortunately, I have a lot to do at the moment. 😞

If there is a β€œdeadline” for the PR, I have a bit of pressure and will certainly get to work more quickly. πŸ˜„

I'm also having problems running the tests on my computer.

RuntimeError: The ZenML database has never been migrated with alembic before. This can happen if you are performing a direct upgrade from a really old version of ZenML. This direct upgrade path is not supported anymore. Please upgrade your ZenML installation first to 0.54.0 or an earlier version and then 
to the latest version.

I get the following error message and can't solve it.

aiakide avatar Nov 26 '24 13:11 aiakide

@aiakide Well I don't want to give you any arbitrary deadline, but we're going to do the next release some time next week, would be nice to have this in obviously :)

For the testing, I think we've solved that on the other PR, correct?

schustmi avatar Nov 28 '24 09:11 schustmi

Closing this in favor of #3332

schustmi avatar Jan 30 '25 19:01 schustmi