zend-db icon indicating copy to clipboard operation
zend-db copied to clipboard

Published 20 hours ago • verified publisher icon zendframework

Add clear docblock to all classes and interfaces

Open fadoe opened this issue 7 years ago • 4 comments

Many classes and interfaces don't have docblocks. A developer and the IDE is not able to know which data should returned. Best example is the TableGatewayInterface.

Can I send an PR for this?

fadoe avatar Dec 28 '17 09:12 fadoe

@fadoe That would be great!

froschdesign avatar Dec 28 '17 10:12 froschdesign

I created a PR, but it is not completed now. I have for example a question about the StatementContainerInterface. Where is the best place for this questions? This issue or the pull request?

fadoe avatar Dec 28 '17 10:12 fadoe

I have a question to the DriverFeatureInterface.

The addFeature in the interface describes the feature as mixed, in Driver\Pdo\Pdo as AbstractFeature. getFeature returns in Driver\Pdo\Pdo AbstractFeature or false (see docblock). Is this a difference between the interface and the extended Pdo class? I think in the DriverFeatureInterface should it also AbstractFeature.

fadoe avatar Dec 29 '17 14:12 fadoe

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at https://github.com/laminas/laminas-db/issues/58.

michalbundyra avatar Jan 16 '20 19:01 michalbundyra