zend-code icon indicating copy to clipboard operation
zend-code copied to clipboard

Deprecate scanner functionality (4.0), drop it (5.0) in favor of

Open Ocramius opened this issue 9 years ago • 3 comments

Basically, parsing via regexes is simply not acceptable/viable anymore, and absolutely doesn't scale, as the syntax of PHP keeps changing.

@asgrim has been building https://github.com/Roave/BetterReflection since last year, and the library is stable/mature, so I'd suggest that we chop the head off this part of zend-code's functionality.

Thoughts?

Ocramius avatar Sep 18 '16 17:09 Ocramius

No problem here, that's the sort of thing BR can do I believe (though I'm not intimately familiar with the scanner here). If there is missing functionality in BR, I'm happy to take PRs or feature requests.

asgrim avatar Sep 19 '16 09:09 asgrim

I'm :+1: for this. While I've been happy we've had this feature in zend-code, it's difficult to maintain, and, particularly with the fast pace of language additions/changes, hard to keep up-to-date. The only way we could accomplish that is with a rewrite to use an AST and/or tokenization approach (the latter of which BR uses, IIRC), which would be a significant undertaking. Since another tool exists, I'd be happy to point folks to that instead.

weierophinney avatar Sep 21 '16 19:09 weierophinney

This repository has been closed and moved to laminas/laminas-code; a new issue has been opened at https://github.com/laminas/laminas-code/issues/17.

weierophinney avatar Dec 31 '19 21:12 weierophinney