Optimize plugin loading with error handling and validation

[devin-ai-integration[bot]]

Optimize plugin loading with error handling and validation

Summary

This PR improves the reliability and user experience of the zeesh-plugin-enable function by adding proper error handling, file existence validation, and better variable scoping. The changes prevent shell errors when plugins are missing or invalid, and provide clear feedback to users about plugin loading issues.

Key changes:

• Add file existence checks before sourcing plugin files
• Implement proper error handling with informative messages to stderr
• Use local variable scoping to prevent global pollution
• Graceful degradation for missing plugins (skip with warning vs. fail)
• Include comprehensive efficiency analysis report documenting additional optimization opportunities

Review & Testing Checklist for Human

Risk Level: 🟡 Medium - Behavior changes require verification

• [ ] Test actual plugin loading in a real zeesh environment with valid plugins (git, autocomplete, etc.) to ensure functionality still works
• [ ] Verify error handling behavior doesn't break existing scripts or workflows that might depend on silent failures
• [ ] Test edge cases: plugins with spaces in names, completely missing plugin directories, malformed plugin files
• [ ] Check stderr output and return codes are acceptable - the function now returns 1 on individual plugin failures and prints error messages

Notes

• This change adds defensive programming but changes behavior - the function now provides error feedback where it previously failed silently
• Manual testing was limited due to environment constraints - successful plugin loading should be verified in a proper zeesh setup
• The efficiency report identifies 6 additional optimization opportunities for future consideration
• Plugin file naming convention ("plugin") is assumed based on codebase analysis

Link to Devin run: https://app.devin.ai/sessions/d1039cb199e647b4b2a91b72dd5ab3a6
Requested by: @zeekay

[devin-ai-integration[bot]]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• [ ] Disable automatic comment and CI monitoring