zeebe-modeler icon indicating copy to clipboard operation
zeebe-modeler copied to clipboard

Wrong Error Message Text When Attempting to Open DMN

Open philippfromme opened this issue 5 years ago • 6 comments

Describe the Bug

Trying to open a non-BPMN file results in an error message with the wrong text.

image

Steps to Reproduce

  1. Try opening a DMN diagram
  2. Error message pops up

Expected Behavior

Error message reads "diagram.dmn" is not a BPMN file.

Environment

  • Zeebe Modeler Version: 0.9.0

philippfromme avatar Apr 16 '20 09:04 philippfromme

@pinussilvestrus Can I take up this issue?

imrishabh18 avatar Sep 28 '20 11:09 imrishabh18

Of course! Feel free to open a PR and/or ask for help if you need some 🚀

pinussilvestrus avatar Sep 28 '20 11:09 pinussilvestrus

What should be the text for the error message then?

imrishabh18 avatar Sep 28 '20 11:09 imrishabh18

There is a hint in the issue description

Error message reads "diagram.dmn" is not a BPMN file.

Despite, you can always come up with another solution if you think there is something better.

pinussilvestrus avatar Sep 28 '20 13:09 pinussilvestrus

Is this card is ready to pick, i would like to work upon.

vvkpd avatar Nov 16 '20 09:11 vvkpd

Feel free to open a PR. There was already work done in this regard: https://github.com/zeebe-io/zeebe-modeler/pull/256, which was not finished.

pinussilvestrus avatar Nov 16 '20 10:11 pinussilvestrus