Themes have terminal foreground/background colors set the same in some cases

[hubertpompecki]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

I keep running into an issue with some text (paths to failing tests in the output of mix test when working with Elixir) not being visible in the Zed terminal. This happens in all colour themes and across multiple Elixir versions. I need to either hover over or highlight the text to see it: I thought this might be somehow related to my zsh config but the issue persists when setting the terminal to sh with:

    "shell": {
      "program": "sh"
    }

When running the same test in iTerm or terminal the path is displayed fine.

Environment

Zed: v0.120.5 (Zed) OS: macOS 14.0.0 Memory: 16 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[bluesbettle]

I can reproduce on: Zed: v.0.120.6 OS: macOS 14.1.2 (Sonoma) Architecture (ARM M1) Shell:

bash --version
GNU bash, version 5.2.15(1)-release

[hubertpompecki]

For anyone running into this, whilst all default colour schemes are affected, I was able to get the missing line to show by using any one of catppuccin themes.

[github-actions[bot]]

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in a week. Feel free to open a new issue if you're seeing this message after the issue has been closed. Thanks for your help!

[hubertpompecki]

Commenting because this still happens with all built-in themes.

[notpeter]

I found reference to this upstream: Mix test hides console output text with black on black colorization?

Its suggests that this text is ansi black + ansi bright; and so perhaps themes with a black terminal background should render this as a color other than just plain black.

[github-actions[bot]]

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!

[notpeter]

I believe this is an upstream issue with mix.

But for anyone running into something similar in light mode, it could also be this.

• https://github.com/zed-industries/zed/issues/29379

Thanks for reporting.