zed icon indicating copy to clipboard operation
zed copied to clipboard

Include the Monokai theme in the default theme selection

Open simylein opened this issue 1 year ago • 8 comments

Check for existing issues

  • [X] Completed

Describe the feature

I would love to see the Monokai theme from vscode as a default theme option in zed. If that's not possible, I am looking forward to the planned theme 1.0 spec for importing custom ones.

If applicable, add mockups / screenshots to help present your vision of the feature

For clarification, those are the theme colours used in vscode (the code is not relevant, its just something to show the various colours) Screenshot 2024-01-26 at 21 19 29

simylein avatar Jan 26 '24 20:01 simylein

Monokai was the default theme for Sublime Text.

(Sublime text is probably considered by most as the most prominent gui editor of the 2010s before the st -> atom -> vscode transition at the end of the decade.)

Adding this theme would absolutely help ease the transition for new users who kept the theme moving forwards or for users who skipped a step or two in the last gui editor transition.

spartanatreyu avatar Jan 29 '24 05:01 spartanatreyu

I would pay $60 right now to have Monokai added. Take my money!

I know customers always say they have "one feature" keeping them from using a product, and sometimes they are blowing smoke. Perhaps letting someone pay $60 for a feature lets them show that they mean it :)

I would love to start using Zed in earnest but my brain is so very tuned to monokai that the speed gains of using Zed (or even the desire to just "kick the tires") are thwarted by my inability to quickly understand my code at-a-glance when it is in a different syntax highlighting style. If Zed exposed a modifiable custom style I'd happily sink 5 hours into that job just to get Monokai working. I can't be the only person with a style that matters deeply to them. Perhaps an "interim" fix that exposes a single configurable "custom" style would let the community author style sheets that could get everyone over the hump of having their own personal "must-have-style" until a broader theming solution shows up in a later version.

In practice I won't actually start using Zed for anything until I can get Monokai working somehow.

Cheers!

epmoyer avatar Feb 03 '24 17:02 epmoyer

image Okay, embarrassingly I forgot that Zed went open source recently :). I managed to get it building, added a new "Monokai" style (copied from Andromeda), and successfully changed one of the colors (strings, to yellow), which means I should be able to create my own local Monokai from here. Wooohooo!!!

If I manage to complete a good conversion then I'll make a PR.

epmoyer avatar Feb 03 '24 20:02 epmoyer

image

I got far enough with my port of Monokai to figure out that today the screenshot above is about as close as you can get (Zed on the left, VSCode on the right). The current capabilities of the syntax highlighter don't allow you distinguish between some elements which Monokai traditionally colors differently (such as called procedure names (blue) vs procedure definitions (green)).

That said, it's close enough to achieve whatI wanted, which was to feel "at home" in Zed.

While I was looking up how to set my font to take the screenshot above I found out that 3 days ago the Zed team Announced that they now support user themes in the "Zed Preview" release. I tried converting the "OneMonokai-color-theme" VSCode theme to Zed using their new theme_importer tool and got the result below (which has the same issues I'd found when doing my own conversion; i.e. that some elements which Monokai would traditionally color differently share the same styling).

image

I've gotten this far so I may as well tie it with a bow and publish what I have. I personally prefer the "bright" version (first screenshot) which I made manually than the lower-contrast of "OneMonokai" (second screenshot) but I will try to publish the latter as well. The OneMonokai repo I used for the conversion is published with an MIT license so I'll be able to post that conversion feely.

Cheers! And thanks Zed team for going open source, and for adding User Theming!!!!!

epmoyer avatar Feb 03 '24 22:02 epmoyer

I have published my Zed Monokai themes (my version and 2 conversions) at Zed Monokai Theme

Share and Enjoy!

epmoyer avatar Feb 03 '24 23:02 epmoyer

I will definitely use it when the 'user themes' feature lands on the stable version. Thank you!

nicodevs avatar Feb 14 '24 12:02 nicodevs

I can't really comment for sure on whether or not we will be pulling in any new themes into Zed, as I'm not on that subteam, but you should definitely open an issue in the new extensions repo to request it to at least be an extension on the store. There already is a Molokai variant on the store at the moment, but probably not the one you are looking for.

  • https://github.com/zed-industries/extensions/issues/new/choose

JosephTLyons avatar Feb 16 '24 18:02 JosephTLyons

Need the full Monokai theme to switch to any editor - currently VSCode has the best implementation

seanaguinaga avatar Apr 17 '24 20:04 seanaguinaga

I was looking into this 😍 Thank you so much @epmoyer I'm a huge fan of Monokai since 12 years ago when I first wrote my own "hello worlds" in Sublime Text 2

d8vjork avatar May 22 '24 09:05 d8vjork

We're not adding additional default themes to Zed, but there are multiple monokai themes available as extensions. image

Thanks y'all.

notpeter avatar Jul 03 '24 14:07 notpeter