zed icon indicating copy to clipboard operation
zed copied to clipboard

Add preview tabs

Open realharley91 opened this issue 1 year ago • 3 comments

This is a POC and would need significant feedback and improvement but it works as far as I could try.

Release Notes:

  • Added preview tabs.

realharley91 avatar Jan 26 '24 15:01 realharley91

Thank you for contributing! :D

Could you add a description of what problem you're trying and maybe a short video or screenshot showing how this PR changes the Zed UI?

mikayla-maki avatar Jan 26 '24 18:01 mikayla-maki

Hi @mikayla-maki, there is a feature called "Preview Tabs" in VSCode.

Screenshot 2024-01-27 at 12 34 53

It displays preview tabs in italic font and they do not persist until interacted with.

Screenshot 2024-01-27 at 12 35 18

So image I have tabs [a, b] currently. If I in succession do these actions:

  • Single click file 'c' from file picker
  • Double click file 'd' from file picker
  • Single click file 'f' from file picker

What I end up in VSCode is [a, b, d, _f_] (_ means preview). This is a useful feature to keep the tab space free of clutter. I personally like and want it in Zed.

Currently in Zed if I follow the same actions I end up with [a, b, c, d ,f]. This hurts my feelings and I get lost in so many open tabs.

The PR is not yet done, as I have yet to implement persisting tabs on interaction part done. I plan to examine how VSCode does it and implement it the next Sunday. It would be a good idea to put a setting option to disable this as well. I highly suggest making it enabled by default, tho it would be better decided by the zed team.

Thanks for reading this long comment 💯

realharley91 avatar Jan 27 '24 09:01 realharley91

Thank you for the description! I see what you’re going for now. For a larger scope user-facing feature like this, we’d love to chat with you about the design of this in source code. If you want to drop by our discord or our fireside hacks or some such, we’d love to support this effort! Good luck on the implementation :D

mikayla-maki avatar Jan 27 '24 18:01 mikayla-maki

Hey! Thanks for this work, we'd love to add this feature but in all of the open source activity I think this one has fallen through the cracks. If you want to re-open it against current main and get this shipped, feel free and I'd be happy to pair on it with you :) https://calendly.com/mikayla-zed

mikayla-maki avatar Feb 09 '24 18:02 mikayla-maki

This should be a higher level issue. On some projects you easily end up with 20+ tabs within minutes just by viewing them in the editor.

SoloReverse avatar Feb 27 '24 03:02 SoloReverse