zed icon indicating copy to clipboard operation
zed copied to clipboard

CRLF lines show as modified lines

Open naim94a opened this issue 1 year ago • 4 comments

Check for existing issues

  • [X] Completed

Describe the bug / provide steps to reproduce it

After cloning a git repository, I realized that files with CRLF line endings always show as modified lines (yellow marker on the left), regardless if they were modified or not (git diff output is empty).

Environment

Zed: v0.118.1 (Zed) OS: macOS 14.2.1 Memory: 36 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

naim94a avatar Jan 04 '24 22:01 naim94a

I would've guessed that Zed changed these these to LF, but you have no changes at all on your end, @naim94a?

JosephTLyons avatar Jan 05 '24 02:01 JosephTLyons

Yup, No modification to the file and it shows that all lines were modified. All lines are converted to LFs if I actually modify the file.

naim94a avatar Jan 05 '24 10:01 naim94a

duplicate of

  • https://github.com/zed-industries/zed/issues/5294

gianpaj avatar May 15 '24 08:05 gianpaj

This could've helped with the diff issue:

  • https://github.com/zed-industries/zed/pull/11519

Could you check Zed 0.136 when it's released today?

All lines are converted to LFs if I actually modify the file.

will stay for now alas and could be solved as part of https://github.com/zed-industries/zed/issues/5294

SomeoneToIgnore avatar May 15 '24 09:05 SomeoneToIgnore

I think this may have been solved by:

  • #11519

@naim94a If you still experience this with a current build please comment and I'm happy to reopen.

notpeter avatar Oct 13 '24 18:10 notpeter