zed-industries
Go To Definition broken on Zed: v0.149.3 (Mac)
Check for existing issues
- [X] Completed
Describe the bug / provide steps to reproduce it
Go To Definition doesn't go to definition
Environment
Zed: v0.149.3 (Zed) OS: macOS 14.1.1 Memory: 64 GiB Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
Go To Definition doesn't go to definition
If applicable, attach your Zed.log file to this issue.
Go To Definition doesn't go to definition
What is the language you're using?
- Svelte https://github.com/zed-industries/zed/issues/16469
- Vue https://github.com/zed-industries/zed/issues/13769
are reported and have a workaround (maybe even a fix) ready.
That issue seems to mention permission issues with *.sh files, so not sure that the same fix applies — but I'll add that just in case too, thank you.
What is the language you're using?
- Svelte Vue "Go to definition" no longer works #16469
- Vue Go to definition not working again in .svelte files #13769
are reported and have a workaround (maybe even a fix) ready.
Svelte, Typescript, Javascript.
Go To definition doesn't work at all.
Thank you. Alas none of those fixes fixed it for me.
I thought it was biome, but removing it didn't help either :(
That is really odd, not related to the fix above then. Could you share settings.json, logs and, ideally, a project to repro things on? (or is it happening everywhere?)
Hey,
i did rm-rf Application Files, reinstalled Zed & Biome, and placed biome as the last element in the array & it's working again.
settings.json
{
"language_models": {
"anthropic": {
"version": "1"
}
},
"theme": "One Dark",
"vim_mode": true,
"vim": {
"use_system_clipboard": "always",
"use_multiline_find": false,
"use_smartcase_find": true
},
"ui_font_size": 16,
"buffer_font_size": 15,
"format_on_save": "on",
"base_keymap": "JetBrains",
"code_actions_on_format": {
"source.fixAll.biome": true,
"source.organizeImports.biome": true
},
"languages": {
"TypeScript": {
"language_servers": ["!typescript-language-server", "!eslint", "biome"]
},
"features": {
"inline_completion_provider": "supermaven"
},
"formatter": {
"external": {
"command": "/Users/zp/.bun/bin/biome",
"arguments": ["format", "--write", "--stdin-file-path", "{buffer_path}"]
}
},
"tab_size": 2,
"tabs": {
"git_status": true,
"close_position": "right"
},
"journal": {
"hour_format": "hour24"
},
"assistant": {
"default_model": {
"provider": "anthropic",
"model": "claude-3-5-sonnet-20240620"
},
"version": "2",
"provider": null
}
}
}
So i don't have the old logs, the logs i have show the moment before i reinstalled the biome extension after copy pasting my settings.json into a fresh Zed install
Caused by:
No such file or directory (os error 2)
2024-08-23T04:08:27.05748-06:00 [INFO] Node runtime install_if_needed
2024-08-23T04:08:27.057961-06:00 [INFO] starting language server "biome", path: "/Users/mockuser/.config/zed/settings.json", id: 14
2024-08-23T04:08:27.05812-06:00 [INFO] starting language server "biome", path: "/Users/mockuser/Workspace/mockproject", id: 15
2024-08-23T04:08:27.058464-06:00 [ERROR] failed to start language server "biome": Error: biome binary not found
2024-08-23T04:08:27.058607-06:00 [ERROR] server stderr: Some("")
2024-08-23T04:08:27.058724-06:00 [INFO] retrying installation of language server "biome" in 1s
2024-08-23T04:08:27.060167-06:00 [ERROR] failed to start language server "biome": Error: biome binary not found
2024-08-23T04:08:27.0603-06:00 [ERROR] server stderr: Some("")
2024-08-23T04:08:27.060416-06:00 [INFO] retrying installation of language server "biome" in 1s
2024-08-23T04:08:27.195108-06:00 [INFO] starting language server. binary path: "/Users/mockuser/Library/Application Support/Zed/node/node-v22.5.1-darwin-arm64/bin/node", working directory: "/Users/mockuser/.config/zed", args: ["/Users/mockuser/Library/Application Support/Zed/languages/json-language-server/node_modules/vscode-langservers-extracted/bin/vscode-json-language-server", "--stdio"]
2024-08-23T04:08:27.233815-06:00 [INFO] Installing default prettier and plugins: [("prettier-plugin-svelte", "3.2.6"), ("prettier", "3.3.3")]
2024-08-23T04:08:27.234004-06:00 [INFO] Node runtime install_if_needed
2024-08-23T04:08:28.065191-06:00 [INFO] About to spawn test binary
2024-08-23T04:08:28.065344-06:00 [WARN] test binary failed to launch
2024-08-23T04:08:28.065428-06:00 [WARN] test binary check failed
2024-08-23T04:08:28.065509-06:00 [INFO] beginning to reinstall server
2024-08-23T04:08:28.065593-06:00 [INFO] About to spawn test binary
2024-08-23T04:08:28.06568-06:00 [WARN] test binary failed to launch
2024-08-23T04:08:28.065762-06:00 [WARN] test binary check failed
2024-08-23T04:08:28.065842-06:00 [INFO] beginning to reinstall server
2024-08-23T04:08:28.069456-06:00 [INFO] deleting server container
2024-08-23T04:08:28.069571-06:00 [INFO] deleting server container
2024-08-23T04:08:28.069842-06:00 [ERROR] server container removal
Caused by:
No such file or directory (os error 2)
2024-08-23T04:08:28.069968-06:00 [ERROR] server container removal
Caused by:
No such file or directory (os error 2)
2024-08-23T04:08:28.070099-06:00 [INFO] starting language server "biome", path: "/Users/mockuser/.config/zed/settings.json", id: 16
2024-08-23T04:08:28.070233-06:00 [INFO] starting language server "biome", path: "/Users/mockuser/Workspace/mockproject", id: 17
2024-08-23T04:08:28.07057-06:00 [ERROR] failed to start language server "biome": Error: biome binary not found
2024-08-23T04:08:28.070679-06:00 [ERROR] server stderr: Some("")
2024-08-23T04:08:28.070782-06:00 [INFO] retrying installation of language server "biome" in 1s
2024-08-23T04:08:28.070909-06:00 [ERROR] failed to start language server "biome": Error: biome binary not found
2024-08-23T04:08:28.071016-06:00 [ERROR] server stderr: Some("")
2024-08-23T04:08:28.071112-06:00 [ERROR] Hit 4 reinstallation attempts for "biome"
2024-08-23T04:08:28.382347-06:00 [INFO] Initialized prettier with plugins: {"prettier-plugin-svelte"}
2024-08-23T04:08:29.085356-06:00 [INFO] About to spawn test binary
2024-08-23T04:08:29.08574-06:00 [WARN] test binary failed to launch
2024-08-23T04:08:29.085942-06:00 [WARN] test binary check failed
2024-08-23T04:08:29.086282-06:00 [INFO] beginning to reinstall server
2024-08-23T04:08:29.091012-06:00 [INFO] deleting server container
2024-08-23T04:08:29.091683-06:00 [ERROR] server container removal
Caused by:
No such file or directory (os error 2)
Having this issue with .svelte & .astro files, here are my logs from svelte
I'm on windows, built from source, 0.151.0 https://github.com/zed-industries/zed/commit/29f97e27559e4006542dccf390e1155415da8530
Go to definition, ctrl + click NOT working.
Caused by:
The system cannot find the file specified. (os error 2)
2024-08-24T17:00:37.8162994+03:00 [INFO] starting language server "emmet-language-server", path: "H:\\dev\\hindsight-bot\\apps\\back", id: 12
2024-08-24T17:00:37.8176069+03:00 [INFO] Node runtime install_if_needed
2024-08-24T17:00:38.0359283+03:00 [INFO] About to spawn test binary
2024-08-24T17:00:38.0360429+03:00 [WARN] test binary failed to launch
2024-08-24T17:00:38.0361074+03:00 [WARN] test binary check failed
2024-08-24T17:00:38.0361728+03:00 [INFO] beginning to reinstall server
2024-08-24T17:00:38.0363166+03:00 [INFO] deleting server container
2024-08-24T17:00:38.0366725+03:00 [ERROR] server container removal
Caused by:
The system cannot find the file specified. (os error 2)
2024-08-24T17:00:38.0368183+03:00 [INFO] starting language server "svelte-language-server", path: "H:\\dev\\hindsight-bot\\apps\\back", id: 13
2024-08-24T17:00:38.0438325+03:00 [INFO] Node runtime install_if_needed
2024-08-24T17:00:38.0443922+03:00 [INFO] starting language server. binary path: "C:\\Users\\Bewinxed\\AppData\\Local\\Zed\\node\\node-v22.5.1-win-x64\\node.exe", working directory: "H:\\dev\\hindsight-bot\\apps\\back", args: ["/C:\\Users\\Bewinxed\\AppData\\Local\\Zed\\extensions\\work\\emmet/node_modules/.bin/emmet-language-server", "--stdio"]
2024-08-24T17:00:38.1329972+03:00 [ERROR] cannot read LSP message headers
2024-08-24T17:00:38.1333229+03:00 [ERROR] failed to start language server "emmet-language-server": oneshot canceled
2024-08-24T17:00:38.1334101+03:00 [ERROR] server stderr: Some("node:internal/modules/cjs/loader:1222\r\n throw err;\r\n ^\r\n\r\nError: Cannot find module 'H:\\C:\\Users\\Bewinxed\\AppData\\Local\\Zed\\extensions\\work\\emmet\\node_modules\\.bin\\emmet-language-server'\r\n at Module._resolveFilename (node:internal/modules/cjs/loader:1219:15)\r\n at Module._load (node:internal/modules/cjs/loader:1045:27)\r\n at TracingChannel.traceSync (node:diagnostics_channel:315:14)\r\n at wrapModuleLoad (node:internal/modules/cjs/loader:215:24)\r\n at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:158:5)\r\n at node:internal/main/run_main_module:30:49 {\r\n code: 'MODULE_NOT_FOUND',\r\n requireStack: []\r\n}\r\n\r\nNode.js v22.5.1\r\n")
2024-08-24T17:00:38.1336856+03:00 [ERROR] Hit 4 reinstallation attempts for "emmet-language-server"
2024-08-24T17:00:38.133832+03:00 [ERROR] server shut down
2024-08-24T17:00:38.2783108+03:00 [INFO] starting language server. binary path: "C:\\Users\\Bewinxed\\AppData\\Local\\Zed\\node\\node-v22.5.1-win-x64\\node.exe", working directory: "H:\\dev\\hindsight-bot\\apps\\back", args: ["/C:\\Users\\Bewinxed\\AppData\\Local\\Zed\\extensions\\work\\svelte/node_modules/svelte-language-server/bin/server.js", "--stdio"]
2024-08-24T17:00:38.3635706+03:00 [ERROR] cannot read LSP message headers
2024-08-24T17:00:38.3639732+03:00 [ERROR] failed to start language server "svelte-language-server": oneshot canceled
2024-08-24T17:00:38.3640554+03:00 [ERROR] server stderr: Some("node:internal/modules/cjs/loader:1222\r\n throw err;\r\n ^\r\n")
2024-08-24T17:00:38.3641579+03:00 [ERROR] Hit 4 reinstallation attempts for "svelte-language-server"
2024-08-24T17:00:38.3642554+03:00 [ERROR] server shut down
2024-08-24T17:00:38.3947787+03:00 [INFO] Creating texture 0x1aa0dba2630 of size 1024x1024x1 and format R16Float, name 'atlas', handle 9
2024-08-24T17:00:38.3951391+03:00 [INFO] Creating buffer 0x1aa0e354970 of size 144144, name 'chunk-6', handle 10
2024-08-24T17:00:40.3171832+03:00 [INFO] Creating a descriptor pool for at most 16 sets
2024-08-24T17:00:40.3282263+03:00 [INFO] Creating a descriptor pool for at most 16 sets
2024-08-24T17:00:40.3390596+03:00 [INFO] Creating a descriptor pool for at most 256 sets
2024-08-24T17:00:40.3501845+03:00 [INFO] Creating a descriptor pool for at most 256 sets
2024-08-24T17:00:46.087208+03:00 [INFO] Creating buffer 0x1aa0e012210 of size 145376, name 'chunk-7', handle 11
2024-08-24T17:00:46.1375525+03:00 [INFO] Creating buffer 0x1aa0e012080 of size 145488, name 'chunk-8', handle 12
2024-08-24T17:00:46.2433888+03:00 [INFO] Creating buffer 0x1aa0e0123a0 of size 145936, name 'chunk-9', handle 13
2024-08-24T17:00:46.7182467+03:00 [INFO] Initializing default prettier with plugins {"prettier-plugin-svelte"}
2024-08-24T17:00:46.718373+03:00 [INFO] starting language servers for TypeScript: vtsls, eslint
2024-08-24T17:00:46.8206776+03:00 [INFO] Language server with id 2 sent unhandled notification eslint/status:
{
"uri": "file:///H:/dev/hindsight-bot/apps/back/src/lib/auth/web3auth.ts",
"state": 1,
"validationTime": 29
}
cmd + click doesn't work for GoTo definition for me either. This is for the Go language. When I hover over a function call and press cmd, it underlines the function and visually indicates that it has become clickable but upon clicking results in no action. I discovered that when I press opt + click then it performs the desired behaviour. But in this case it doesn't have the visual cues that holding down cmd has. I don't have any custom key bindings either.
System Details OS: macOS Sequoia 15.01 Chip: Apple M2 Memory: 8GB Model: MacBook Air Zed Version: 0.157.5
Relevant settings:
{
"multi_cursor_modifier": "cmd_or_ctrl",
"lsp": {
"gopls": {
"initialization_options": {
"analyses": {
"shadow": true,
"unusedvariable": true,
"useany": true
},
"codelenses": {
"gc_details": true,
"run_govulncheck": true,
"test": true
},
"hints": {
"assignVariableTypes": true,
"compositeLiteralFields": true,
"compositeLiteralTypes": true,
"constantValues": true,
"functionTypeParameters": true,
"parameterNames": true,
"rangeVariableTypes": true
},
"importShortcut": "Both",
"staticcheck": true,
"usePlaceholders": true,
"vulncheck": "Imports"
}
}
}
}
I'm experiencing this issue on Zed 0.157.5 with Rust (rust-analyzer) and default settings on macOS. Haven't bothered trying all the possible debug steps since there are already so many examples in this thread but let me know if there's anything I can do to help.
For me, some definitions can be cmd+clicked to go to definition and some cannot with no clear pattern: some variables work and some do not, some types work and some do not, some struct fields work and some do not, etc.
Renaming symbols is working sporadically as well. Using F2 to rename a symbol renames it in some places but not all, which does make the product unusable for me at the moment.
Update: seeing this in VSCode as well so probably safe to assume it's an LSP issue, at least in my case
cmd + clickdoesn't work for GoTo definition for me either. This is for the Go language.
I am facing the same issue for Java as well. These are the LSP settings for Java:
{
"lsp": {
"jdtls": {
"initialization_options": {
"settings": {
"java": {
"codeAction": { "sortMembers": { "avoidVolatileChanges": true } },
"completion": {
"enabled": true,
"guessMethodArguments": true
},
"format": {
"comments": { "enabled": true },
"enabled": true,
"insertSpaces": true,
"onType": { "enabled": true },
"tabSize": 4
},
"home": "/Path/to/java/binary/java/21.0.3-tem/bin/java",
"implementationsCodeLens": { "enabled": true },
"import": {
"exclusions": [
"**/node_modules/**",
"**/.metadata/**",
"**/archetype-resources/**",
"**/META-INF/maven/**",
"/**/test/**"
],
"gradle": {
"annotationProcessing": { "enabled": true },
"enabled": true,
"home": "/Path/to/gradle/binary/gradle/current/bin/gradle",
"offline": { "enabled": false }
},
"maven": {
"enabled": true,
"offline": { "enabled": false }
}
},
"jdt": { "ls": { "lombokSupport": { "enabled": true } } },
"referenceCodeLens": { "enabled": true },
"rename": { "enabled": true },
"saveActions": { "organizeImports": true },
"signatureHelp": {
"enabled": true,
"description": { "enabled": true }
}
}
},
"workspaceFolders": ["file:///Path/to/java/workspace/directory/java"]
}
}
}
}
Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. If you are able to reproduce this issue in the latest version of Zed, please let us know by commenting on this issue, and we will keep it open. If you can't reproduce it, feel free to close the issue yourself. Otherwise, we'll close it in 7 days. Thanks for your help!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue was closed due to inactivity. If you're still experiencing this problem, please open a new issue with a link to this issue.