zed icon indicating copy to clipboard operation
zed copied to clipboard

Request for GTK theme support in Zed editor

Open millan242 opened this issue 1 year ago • 9 comments

Check for existing issues

  • [X] Completed

Describe the feature

It would be beneficial if the Zed editor could support GTK themes to provide a consistent user experience across the desktop environment.

Current Behavior: Zed editor uses its default theme regardless of the GTK theme applied to the system.

Desired Behavior: The Zed editor should automatically adopt the system-wide GTK theme, including font settings, window decorations, and color schemes, to ensure visual consistency with other GTK applications.

Use Case: Many users prefer a unified look and feel for their applications, especially those using GTK-based desktop environments like GNOME and XFCE.

Additional Information: Operating System: Ubuntu 24.04 LTS x86_64 GTK Theme: WhieSur GTK theme Zed Editor Version: 0.144.4

If applicable, add mockups / screenshots to help present your vision of the feature

Screenshot from 2024-07-20 22-58-12

millan242 avatar Jul 20 '24 17:07 millan242

Implementing GTK theming would be a difficult task and probably not a good idea (mainly on the technical side). However, adding Freedesktop accent color support would be quite nice.

Here's a good article on the matter: https://cassidyjames.com/blog/freedesktop-accent-colors-gnome-proposal/

From https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Settings.html:

org.freedesktop.appearance accent-color ((ddd)) Indicates the system’s preferred accent color as a tuple of RGB values in the sRGB color space, in the range [0,1]. Out-of-range RGB values should be treated as an unset accent color.

Also want to clarify:

font settings, window decorations

Those are not related to the GTK theme. I'm not sure what you mean by the latter, but the former can be fixed separately.

apricotbucket28 avatar Aug 05 '24 22:08 apricotbucket28

Those are not related to the GTK theme. I'm not sure what you mean by the latter, but the former can be fixed separately.

This refers to the bar at the top of the window, which has different close/minimize/maximize icons and layout from all GTK apps (and soon, QT apps as well). GNOME doesn't even support server-side decorations, so libdecor might be the only solution.

LSeelig avatar Aug 09 '24 17:08 LSeelig

Just saying, having a Gnome-GTK-ish top bar will go a long way in making Zed feeling much more integrated in the UI.

adityainduraj avatar Aug 18 '24 06:08 adityainduraj

And make sure use gtk4

olumolu avatar Aug 26 '24 14:08 olumolu

Hello :wave:

Any progress/solution?

searge avatar Oct 01 '24 17:10 searge

Related issue: https://github.com/zed-industries/zed/issues/14120

searge avatar Oct 01 '24 17:10 searge

Really looking forward to this, I use custom button themes (WhiteSur-dark-solid) and so it really throws me off that I don't have those. I figured out how to do it with jetbrains which really helped but I am mainly using zed now.

For anyone possibly using jetbrains: https://youtrack.jetbrains.com/issue/IJPL-43747/2023.2-IDE-Window-frame-does-not-respect-GTK-Theme

s-kiser avatar Mar 30 '25 17:03 s-kiser

I came here just for this. I too use WhiteSur-dark-solid and need the window close/minimize/maximize buttons to be on the left side of the window, so the lack of system window decorations turns into a usability issue.

rcarmo avatar May 13 '25 23:05 rcarmo

I came here just for this. I too use WhiteSur-dark-solid and need the window close/minimize/maximize buttons to be on the left side of the window, so the lack of system window decorations turns into a usability issue.

I have mine on the left side too!

s-kiser avatar May 14 '25 07:05 s-kiser

i was wondering if gtk theme-ing is required for system theme detection. zed for me doesnt switch between light and dark mode as it should.

i use hyprland. and i use gtk settings (nwg-look) to toggle themes, it works in vscode, chrome etc but no in zed. i wonder if it works

xidsyed avatar Oct 17 '25 12:10 xidsyed