zed icon indicating copy to clipboard operation
zed copied to clipboard

Add copy path and copy relative path to context click menu

Open williamdes opened this issue 1 year ago • 1 comments

Release Notes:

  • Added "Copy path" and "Copy relative path" to the file right click context menu

Related to https://github.com/zed-industries/zed/issues/4474

This replicates the tab behavior that exists on vscode image

Tasks:

  • [x] Check that it works on context menu in file image ~~- [ ] Check that it works on a tab (does nothing)~~

williamdes avatar Apr 29 '24 17:04 williamdes

I only implemented for the context menu in a file, I am unable to make it work for a tab. It is better to merge this one without the tab click. Maybe someone will make it or help me do it some day :)

williamdes avatar May 04 '24 08:05 williamdes

It doesn't seem like VSCode includes this in it's mouse context menu:

Screenshot 2024-05-06 at 2 05 25 PM

As such, I don't think this is the right place for this action contextually. It should be on the tabs and the project panel.

mikayla-maki avatar May 06 '24 21:05 mikayla-maki

As such, I don't think this is the right place for this action contextually. It should be on the tabs and the project panel.

I tend to agree but failed implementing it. Could someone let me know why my action was doing nothing?

williamdes avatar May 06 '24 21:05 williamdes

Without a code sample or otherwise looking at the problem, I couldn't tell you. I suggest jumping in our discord and asking once you have one though :)

mikayla-maki avatar May 06 '24 21:05 mikayla-maki

Could you send me an invite link?

Here was my implementation https://github.com/zed-industries/zed/commit/91dc9a39bf7a06f2411567305d9a2f179b81c9f3

williamdes avatar May 06 '24 21:05 williamdes

Hmmm, it should be available somewhere? Regardless, here's the link: https://discord.gg/29HzRq8V

mikayla-maki avatar May 06 '24 21:05 mikayla-maki

Sorry to see that this seems to be abandoned. Has there been newer work implementing this on tabs? I am missing this now. Should I open a new feature request issue?

mattfbacon avatar Jul 08 '24 22:07 mattfbacon

Sorry to see that this seems to be abandoned. Has there been newer work implementing this on tabs? I am missing this now. Should I open a new feature request issue?

Yes please, if you can get this implemented it would be lovely. I really miss my patched version.

williamdes avatar Jul 09 '24 08:07 williamdes

See linked PR, I have the basic functionality but it doesn't work for all types of tabs yet.

mattfbacon avatar Jul 09 '24 09:07 mattfbacon