Make the vim mode indicator a button that toggles mode

[elkowar]

This PR updates the vim mode indicator status bar element to be a button. This is primarily done for consistency: previously, all other entries in the status bar where buttons, except the vim mode indicator. This also meant that the mode indicator would appear one pixel higher than the other entries, throwing off visual consistency.

I also replaced the two minuses around the mode indicator with an endash, which makes the status bar appear a lot cleaner.

Release Notes:

• Fixed visual consistency of the vim indicator being one pixel higher than everything else in the status bar
• Turned vim mode indicator into a button that toggles between insert and normal mode

[DissolveDZN]

That's nice but how about a drop down for all possible vim modes? Because i feel like if you have a button that indicates the current mode like visual mode etc. it should be able to toggle between all of them

[baldwindavid]

how about a drop down for all possible vim modes

Thanks for the work on this. I'd maybe lean the other way here and don't really think it's necessary to do anything (neither toggle nor dropdown) other than reporting the current mode. Seems like yagni for anyone using vim, but that's just me. I personally think limiting the changes to eliminating that one pixel discrepancy (which I now can't unsee! haha) and the en dash are a nice bit of polish.

[ConradIrwin]

Thanks for taking a pass at this!

I hadn't noticed the misalignment of the labels, but you are totally right (current version is on the bottom)

I think we should fix this without making it a button, because it's not very useful to click on. PR is https://github.com/zed-industries/zed/pull/10962.

I am also going to keep the -- over the — as a nod to vim's design language; but it is definitely retro.