zed icon indicating copy to clipboard operation
zed copied to clipboard

Add ability to move search to left bar

Open Rafi993 opened this issue 1 year ago • 3 comments

Check for existing issues

  • [X] Completed

Describe the feature

  • Add ability to move search to left bar similar to VSCode. This helps to quickly search code when you are still viewing the rest of the code
  • This could be a setting that can be turned on for VSCode users who want this to feel at home

If applicable, add mockups / screenshots to help present your vision of the feature

Screenshot 2024-04-15 at 9 42 30 AM

Rafi993 avatar Apr 15 '24 04:04 Rafi993

I've used VSCode search quite a lot so I get it that it can be tough doing things a different way. However, one of the most powerful concepts in Zed is the "multi-buffer" and that is what project search leverages to display results. I don't know what all search-related features might be planned or will evolve (e.g. find/replace live diff), but what is being requested here seems a likely departure from the vision or, if nothing else, implies major UI/UX changes/additions.

helps to quickly search code when you are still viewing the rest of the code

Worth mentioning that I use this flow many times per day with a project-wide search (workspace: new search) and then navigating through the multi-buffer results like any regular buffer. Sometimes, I make changes directly in the multi-buffer and then save, which saves all the changes in the multi-buffer in one go. Other times, I want to see the result in context so will open to the side (editor: open excerpts split) and make changes. Personally, I find this to be a quite natural experience, but ymmv after giving it a good run.

baldwindavid avatar Apr 15 '24 13:04 baldwindavid

I've used VSCode search quite a lot so I get it that it can be tough doing things a different way. However, one of the most powerful concepts in Zed is the "multi-buffer" and that is what project search leverages to display results. I don't know what all search-related features might be planned or will evolve (e.g. find/replace live diff), but what is being requested here seems a likely departure from the vision or, if nothing else, implies major UI/UX changes/additions.

helps to quickly search code when you are still viewing the rest of the code

Worth mentioning that I use this flow many times per day with a project-wide search (workspace: new search) and then navigating through the multi-buffer results like any regular buffer. Sometimes, I make changes directly in the multi-buffer and then save, which saves all the changes in the multi-buffer in one go. Other times, I want to see the result in context so will open to the side (editor: open excerpts split) and make changes. Personally, I find this to be a quite natural experience, but ymmv after giving it a good run.

The problem with editor: open excerpts split and creating a new search workspace is on the left is, If you navigate to a specific instance highlighted item it will it navigate away from the search. Again I'm not saying that existing search should be replaced. But instead add a setting so that search can be moved to left nav for those who wants to (turned off by default) since it will improve adoption from VSCode users.

Rafi993 avatar Apr 16 '24 11:04 Rafi993

If you navigate to a specific instance highlighted item it will it navigate away from the search.

Yep, I actually want the ability to stay in the search area too sometimes. One feature that will ship in the Preview Release tomorrow is Preview Tabs. I'm thinking that perhaps editor: open excerpts split could change to "not" navigate to the file (similar to how it works for the project panel) and then maybe an editor: open permanent excerpts split command could be added. Either that or maybe editor: open excerpts split takes an argument for keymaps whether to open permanent or not. Anyway, maybe something to consider. cc @bennetbo @ConradIrwin

baldwindavid avatar Apr 17 '24 01:04 baldwindavid

Worth mentioning that I use this flow many times per day with a project-wide search (workspace: new search) and then navigating through the multi-buffer results like any regular buffer. Sometimes, I make changes directly in the multi-buffer and then save, which saves all the changes in the multi-buffer in one go. Other times, I want to see the result in context so will open to the side (editor: open excerpts split) and make changes. Personally, I find this to be a quite natural experience, but ymmv after giving it a good run.

From your reply, I can see that you are an experienced user of multi buffers. If it's convenient for you, I'd like to ask you a question: In VSCode, I can filter out the file directory structure related to the search results in the sidebar based on the search results, so that I can get the directory structure in a concentrated manner. Is there any way I can achieve this in Zed?

Thank you for your contributions and informations. Thank you!

GOWxx avatar May 18 '24 05:05 GOWxx

Will zed consider a live_grep similar to fzf or vscode's new added quick search? If I just want a specific location that way is much efficient than glance through multi-buffer results.

@GOWxx I think you can filter here 截屏2024-06-01 10 45 35

xzbdmw avatar Jun 01 '24 02:06 xzbdmw

I think you can filter here

Thank you for your reply. I understand that I can search and filter in the buffer area, but my focus is on the sidebar, which displays the project's directory file structure. I'm looking for a way to filter the directory file structure based on the files found in the search results. A similar example I expect is the 'Source Control' panel in VSCode, which filters out the directory file structure based on the changes made. By the way, the current git diff in Zed cannot filter out and display only the modified directory file structure; it uses color markings instead.

GOWxx avatar Jun 03 '24 10:06 GOWxx

In VSCode, I can filter out the file directory structure related to the search results in the sidebar based on the search results, so that I can get the directory structure in a concentrated manner.

now we have outline panel. Introduce an outline panel #12637

GOWxx avatar Jun 22 '24 03:06 GOWxx

In VSCode, I can filter out the file directory structure related to the search results in the sidebar based on the search results, so that I can get the directory structure in a concentrated manner.

now we have outline panel. Introduce an outline panel #12637

He is a machine:-

xzbdmw avatar Jun 22 '24 03:06 xzbdmw