extensions icon indicating copy to clipboard operation
extensions copied to clipboard

Published 20 hours ago • verified publisher icon zed-industries

Add Synthwave extension

Open DanielMSchmidt opened this issue 1 year ago • 1 comments
trafficstars

DanielMSchmidt avatar Feb 17 '24 16:02 DanielMSchmidt

@DanielMSchmidt It looks like the theme file is missing the required author field:

https://github.com/DanielMSchmidt/zed-synthwave/blob/341bd0429bb33351c8012e772d416322c9598256/themes/synthwave-84.json#L2-L3

It should appear at the top-level next to name and appearance.

maxdeviant avatar Feb 18 '24 15:02 maxdeviant

@maxdeviant I added an author field, the theme_importer did not emit it unfortunately :D

DanielMSchmidt avatar Feb 19 '24 08:02 DanielMSchmidt

@DanielMSchmidt It looks like the structure of the theme file still isn't quite right.

It looks like the theme is top-level instead of being nested in the themes array (a theme file can contain multiple themes).

If you add this field to the top-level of the theme file it should give you JSON schema validation warnings:

"$schema": "https://zed.dev/schema/themes/v0.1.0.json"

Here's an example of what the theme structure looks like: https://github.com/zed-industries/zed/blob/db0eaca2e5a1bbea2bf0192429ab7f3320e38a60/assets/themes/one/one.json

maxdeviant avatar Feb 20 '24 16:02 maxdeviant

Hey @DanielMSchmidt, I opened up a PR to help here. This should resolve the schema errors.

https://github.com/DanielMSchmidt/zed-synthwave/pull/1

JosephTLyons avatar Feb 23 '24 07:02 JosephTLyons