Add an extension for WebIDL

[padenot]

trafficstars

WebIDL is the language we (browser implementors) use to specify Web interfaces. Its own spec is at https://webidl.spec.whatwg.org/, and you can find examples of uses all over, e.g. https://w3c.github.io/webcodecs/#videodecoder-interface.

We use those exact files (literaly copy/pasted) as the input for a binding generator, when implement new features in Web browsers, so we often edit them when working on browsers.

The underlying tree-sitter grammar is a work in progress, as I'm learning tree-sitter itself, but it is enough to correcly highlight most of the WebIDL files I threw at it from within the Firefox repo, and uninstall vscode.

[cla-bot[bot]]

We require contributors to sign our Contributor License Agreement, and we don't have @padenot on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

[notpeter]

Hi @padenot we need you to sign the Zed CLA. Thank you.

[padenot]

Yes, thanks, this is being process by our legal team. They said it's not problem and should be rubberstamped very soon.

[padenot]

@notpeter, actually I had an answer.

Is it possible for Mozilla Corporation (my employer) to sign the CLA instead of me signing it individually, so that my contributions are covered under that, as Mozilla Corporation employee? The person responsible for this on our side tried logging in himself but only had the option to sign the CLA has himself and not as the company.

[notpeter]

As currently implemented, our CLA PR check is via clabot. I believe clabot takes the email address for each PR git commit author and cross references that against emails associated with GitHub usernames. It then issues a checks those usernames against a REST API we maintain to confirm whether a github username has signed the Zed CLA.

We don't currently have a process for an organization to sign-off for employee contributions (nor a process for confirming a given github user is still a member of that organization for future contributions).

Do you know how this is handled with Mozilla employees making contributions to other open source projects that require CLAs? Do other clabot alternatives have an org-level auth flow?

[danielnazer]

I believe you can set up a CLA bot in GitHub to handle both an individual and company-level auth flow. E.g. https://github.com/opendp/clabot-config

We can have @padenot sign for now if that can't be set up quickly but we do prefer signing as Mozilla if folks will be contributing in their capacity of Mozille employees (and think it's better for projects to have two flows so that the authority for the CLA authorization is clearer)

[notpeter]

Thanks @danielnazer, we use a slightly different clabot-config, where instead of a repo with contributor.json, we maintain an endpoint which clabot hits with the github username to validate, but what your suggesting should be possible. Although opendp/clabot-config supports company signatures, there haven't actually accepted any of those, so I'm not positive about the expected flow. Similarly, because they haven't actually had to deal with it, they've sort of punted on the idea of how to handle revocation.

To be clear, you're looking for an alternate flow where you as an company representative could sign on behalf of each individual contributor, not something where we magically pulled in orgs/mozilla/people or anything like that, right?

I'll raise the idea internally and see what I can do.

[danielnazer]

Ideally the CLA flow should allow people to either select 'sign as an individual contributor', 'sign as a corporate contributor', or 'my company has already signed'

For folks that select "my company has already signed" sometimes people include a drop down of companies that have signed where they select which company they work for (iirc the Linux Foundation CLA bot is like this). Otherwise you could check folks email domain matches or just take their word for it (you already have to take folks' word for it that they are actually authorized when they sign the individual CLA)

For another example within GH that has corporate flow: https://github.com/tensorflow/tensorflow/blob/master/CONTRIBUTING.md - though it links out to Google's overall CLA process I think.

[padenot]

I've now signed it on my own per @danielnazer's instructions, and he's keeping track of it on Mozilla's side.

@notpeter, what are the next steps here?

[notpeter]

@cla-bot check

[cla-bot[bot]]

The cla-bot has been summoned, and re-checked this pull request!

[notpeter]

All set! Thanks for the contribution @padenot!