react-simple-maps icon indicating copy to clipboard operation
react-simple-maps copied to clipboard

Make useZoomPan initialize position on mount

Open raksooo opened this issue 5 years ago • 0 comments

This PR changes useZoomPan to make sure that position is initialized to the correct values on the first render, instead of the value { x: 0, y: 0, k: 1 }.

The problem with using { x: 0, y: 0, k: 1 } is that when it's used together with CSS transitions the map transitions from that value to the correct one immediately when loaded instead of just starting with the correct position without transitioning.

This PR fixes #228

I have tested this with my scenario which is a pretty simple one and it seems to work as expected but it might need some more testing in other use cases.

I hope this works well and can be merged since it would help me a lot! Let me know if anything needs to be explained or changed.

raksooo avatar Sep 11 '20 11:09 raksooo