librustzcash icon indicating copy to clipboard operation
librustzcash copied to clipboard

Dynamic confirmation height

Open braddmiller opened this issue 5 years ago • 2 comments

As a wallet developer I'd like to be able to set the minimum number of confirmations required to spend Sapling funds in my wallet front end.

Context: Currently the confirmation height to allow funds to be spendable in our mobile apps are set by librustzcash at 10. This logic should be dynamic and respond to input from the wallet developer instead of being hardcoded at the librustzcash level.

Criteria:

  • [ ] librustzcash can set the confirmation height dynamically for funds based on an input from a library that uses librustzcash (the Android SDK for instance).

braddmiller avatar Dec 02 '19 17:12 braddmiller

See also https://github.com/zcash/zcash/issues/1614 which links to security issues and UX around this problem (which motivated fixing the confirmation level at 10 in the first place).

str4d avatar Dec 02 '19 18:12 str4d

We'll stick with 10 for now. This can be shelved until more conversations and research around confirmation heights in general have been had.

braddmiller avatar Mar 10 '20 18:03 braddmiller