librustzcash icon indicating copy to clipboard operation
librustzcash copied to clipboard

equihash: Add Rust API for Tromp solver

Open str4d opened this issue 1 year ago • 9 comments
trafficstars

str4d avatar Jan 04 '24 04:01 str4d

Codecov Report

Attention: Patch coverage is 57.37705% with 26 lines in your changes missing coverage. Please review.

Project coverage is 54.37%. Comparing base (0432867) to head (f3d5a5c). Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
components/equihash/src/tromp.rs 0.00% 26 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1083   +/-   ##
=======================================
  Coverage   54.36%   54.37%           
=======================================
  Files         175      176    +1     
  Lines       20325    20385   +60     
=======================================
+ Hits        11050    11084   +34     
- Misses       9275     9301   +26     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 04 '24 19:01 codecov[bot]

Force-pushed to clean up the commit history; no changes to @teor2345's changes, just regrouping them (and squashing some of the fixes into the original commits that didn't make sense to keep in standalone commits).

str4d avatar Apr 18 '24 20:04 str4d

Force-pushed to GitHub-linkify an imported source link in a commit message.

str4d avatar Apr 18 '24 20:04 str4d

And somehow I managed to click two wrong buttons in a row 🤦

str4d avatar Apr 18 '24 20:04 str4d

Force-pushed to clean up the feature flagging in the build script, and add C #ifdefs to prevent some warnings.

str4d avatar Apr 18 '24 20:04 str4d

Rebased on current main. I will rebase this PR again once #1357 merges.

str4d avatar Apr 18 '24 23:04 str4d

Rebased on main to fix merge conflicts after #1357 was merged.

str4d avatar Apr 19 '24 02:04 str4d

Force-pushed to move the new minimal-form compression methods into the new submodule from #1357.

str4d avatar Apr 19 '24 02:04 str4d

Force-pushed to adjust the minimal-form compression method APIs and integrate them into the existing tests.

str4d avatar Apr 19 '24 02:04 str4d

Do we want to merge this one? It's blocking us from restoring the internal-miner feature in zebra

mpguerra avatar Nov 14 '24 09:11 mpguerra