numcodecs icon indicating copy to clipboard operation
numcodecs copied to clipboard

Published 20 hours ago • verified publisher icon zarr-developers

Move to pyproject.toml

Open jakirkham opened this issue 3 years ago • 5 comments

It would be good to move to pyproject.toml in Numcodecs. In particular it would be nice to add build requirements (like Cython) and setup_requires to pyproject.toml.

This should also allow us to do things like dropped the vendored C files, which cause us some pain periodically ( https://github.com/zarr-developers/numcodecs/pull/358#issuecomment-1281371763 ). Plus drop some of the complexity in setup.py.

FWIW this was done for Zarr in PR ( https://github.com/zarr-developers/zarr-python/pull/1158 ).

jakirkham avatar Oct 17 '22 20:10 jakirkham

cc @Saransh-cpp @joshmoore

jakirkham avatar Oct 17 '22 20:10 jakirkham

This might get a bit tricky because of the Cython code. I'll try to look into this!

Saransh-cpp avatar Oct 19 '22 09:10 Saransh-cpp

Yep that's definitely true. Even an incremental move or moving most things over would be a welcome improvement 🙂

jakirkham avatar Oct 19 '22 23:10 jakirkham

Thanks, @Saransh-cpp. 🙏🏽

joshmoore avatar Oct 24 '22 10:10 joshmoore

We have the beginnings of a pyproject.toml with PR ( https://github.com/zarr-developers/numcodecs/pull/369 ). Though more work in this area would be welcome 🙂

cc @DimitriPapadopoulos (in case this is of interest as well)

jakirkham avatar Oct 28 '22 17:10 jakirkham

Submitted PR ( https://github.com/zarr-developers/numcodecs/pull/382 ), which moves as much as we can to pyproject.toml. Not sure if there is anything else we can move (though feedback on that would be welcome). Also am familiarizing myself with the process so may well have missed things that others will catch.

jakirkham avatar Nov 03 '22 05:11 jakirkham

There may be small follow up things that come up. Would suggest raising them in new issues. Thanks all! 🙏

jakirkham avatar Nov 08 '22 09:11 jakirkham