zammad-admin-documentation icon indicating copy to clipboard operation
zammad-admin-documentation copied to clipboard

Improved webhook logs documentation with debugging and testing details

Open ssganesh035 opened this issue 9 months ago • 5 comments

  1. Expanded details on webhook request and response attributes.
  2. Added a Debugging Webhook Issues section to help diagnose failures.
  3. Improved readability and structure for better comprehension.

ssganesh035 avatar Feb 16 '25 10:02 ssganesh035

Hi @ssganesh035,

thanks a lot for your contribution! However, your PR should be slightly tweaked:

  • Please select pre-release as merge target branch
  • Execute a make gettext to update the translation catalog and commit them
  • Rephrase line 30+ to something like: Before deploying webhooks in production, you can use testing tools to inspect and debug requests. If you do so, make sure to exclude any sensitive or personal data. And then add the example services.

ralf401 avatar Feb 17 '25 14:02 ralf401

Hi @ralf401, hope you are doing well. I have commited the suggested changes, I believe it's good to go now.

ssganesh035 avatar Feb 21 '25 10:02 ssganesh035

Not yet. It seems you just changed the base branch and didn't rebase/update it to the current pre-release branch.

Please do that and make sure to execute the make gettext before committing. The PR may have no conflict before running the CI checks.

Thank you!

ralf401 avatar Feb 24 '25 13:02 ralf401

Hi @ssganesh035, any news about that? Feel free to rebase and push. Alternatively, I could create a new PR with your suggested changes.

ralf401 avatar Mar 10 '25 16:03 ralf401

Hi @ralf401, I will do the needful and update you

ssganesh035 avatar Mar 11 '25 16:03 ssganesh035

Hi @ssganesh035, what about the update of your PR? I understood that you wanted to updated it, right?

ralf401 avatar Apr 28 '25 07:04 ralf401

Hey @ralf401, hope you are doing well. Could you create a new PR with the suggested changes, as I am unable to execute make gettext. Thanks!

ssganesh035 avatar Apr 28 '25 12:04 ssganesh035

Hi @ralf401, kindly let me know if there's an update

ssganesh035 avatar May 05 '25 20:05 ssganesh035

@ssganesh035 not yet. I'll take a look in the next days...

ralf401 avatar May 07 '25 10:05 ralf401

Cool, thanks!

ssganesh035 avatar May 09 '25 11:05 ssganesh035

Hi @ssganesh035 I created a PR here and close your PR now. Thanks for your contribution!

ralf401 avatar May 09 '25 14:05 ralf401