Zach Silveira

This was the first thing I ever wrote in js. Please don't use this library. Sorry, I should put this in the readme.

it should be passing back the response as well: https://github.com/navjobs/upload/blob/master/src/request/register-listeners.js#L21

In my apps I am navigating to a new page so the component becomes unmounted. It seems like you’d remove the upload component from the page on success and render...

Would adding a prop that resets the state the moment an upload finishes solve the problem?

Cool, I’ll add this tomorrow On Thu, Oct 5, 2017 at 00:56 Kyriakos Z. wrote: > Thar would solve it, yes! > > — > You are receiving this because...

Try @navjobs/[email protected] and add `reset` to the uploader. It's times like these where I wish I was a better dev 6 months ago, could have made this better code-wise haha

sure, ill do that instead and make a new release.

I'm actually not sure of a good way to do this, calling reset will cause a state change inside the render, kind of the reason I wish i didnt have...

Checking componentWillReceiveProps to do an action is a really bad paradigm, and the way I built this component kind of forces you into bad habits like this. I want to...

@bionicvapourboy when upload is complete, reload the page for now (push to the upload page in react router or something), I have this on my list to rewrite this component...