node-red-contrib-home-assistant-websocket icon indicating copy to clipboard operation
node-red-contrib-home-assistant-websocket copied to clipboard

Existence of issues with Home Assistant nodes destroys node red gui header

Open bwims opened this issue 8 months ago • 8 comments

Describe the bug

I recently upgraded the Home Assistant Node Red Companion to 4.1.2 under NR 3.1.4 Some of my flows had nodes with missing HA entities and a new indicator appeared in the toolbar of Node Red. Unfortunately, it totally corrupts the toolbar so it is very difficult to deploy or invoke the hamburger menu.

Image

The problem appears to be a combination of the HA logo and the font size of the message.

To Reproduce

  1. install NR companion 4.1.2 (I was running a much earlier version)
  2. add a call service node referencing a no-longer extant entity
  3. deploy.

Expected behavior

Presumably messages appear in the toolbar without corruption?

Screenshots

As above

Image

Example Flow

[
    {
        "id": "8b7cd48e431eb2ad",
        "type": "api-current-state",
        "z": "ef12f8530d02e6bf",
        "name": "",
        "server": "bb97bd2097fb0698",
        "version": 3,
        "outputs": 1,
        "halt_if": "",
        "halt_if_type": "str",
        "halt_if_compare": "is",
        "entity_id": "I_dont_exist",
        "state_type": "str",
        "blockInputOverrides": true,
        "outputProperties": [
            {
                "property": "payload",
                "propertyType": "msg",
                "value": "",
                "valueType": "entityState"
            },
            {
                "property": "data",
                "propertyType": "msg",
                "value": "",
                "valueType": "entity"
            }
        ],
        "for": "0",
        "forType": "num",
        "forUnits": "minutes",
        "override_topic": false,
        "state_location": "payload",
        "override_payload": "msg",
        "entity_location": "data",
        "override_data": "msg",
        "x": 460,
        "y": 200,
        "wires": [
            [
                "64620cd92f6915d9"
            ]
        ]
    },
    {
        "id": "44a52e73cb0d7cc9",
        "type": "inject",
        "z": "ef12f8530d02e6bf",
        "name": "",
        "props": [
            {
                "p": "payload"
            },
            {
                "p": "topic",
                "vt": "str"
            }
        ],
        "repeat": "",
        "crontab": "",
        "once": false,
        "onceDelay": 0.1,
        "topic": "",
        "payload": "",
        "payloadType": "date",
        "x": 200,
        "y": 200,
        "wires": [
            [
                "8b7cd48e431eb2ad"
            ]
        ]
    },
    {
        "id": "64620cd92f6915d9",
        "type": "debug",
        "z": "ef12f8530d02e6bf",
        "name": "debug 491",
        "active": true,
        "tosidebar": true,
        "console": false,
        "tostatus": false,
        "complete": "false",
        "statusVal": "",
        "statusType": "auto",
        "x": 710,
        "y": 200,
        "wires": []
    }
]

Environment Information

Version: 0.75.0

Home Assistant version: 2025.1.3 Companion version: 4.1.2

Node-RED version: 3.1.4 Docker: yes Add-on: no

Node.js version: v18.19.0 arm64 linux OS: Linux 5.15.32-v8+ arm64

(Please note: the link above for diagnostic information button should be a pop-out; I though I had lost all my typing!)

Additional context

No response

bwims avatar Mar 18 '25 14:03 bwims

What OS, browser, and version are you using?

zachowj avatar Mar 19 '25 02:03 zachowj

Windows 10 Brave Version 1.76.74 Chromium: 134.0.6998.89 (Official Build) (64-bit) Microsoft Edge Version 134.0.3124.72 (Official build) (64-bit)

bwims avatar Mar 19 '25 16:03 bwims

Apologies for the delay in replying! I hope those browsers are acceptable. I won't install Chrome!

bwims avatar Mar 19 '25 16:03 bwims

I can't reproduce this on Node-RED v4. I'll have to test it on version 3.

zachowj avatar Mar 20 '25 01:03 zachowj

I don't have any v4 instances as yet.

Thanks!

On Thu, 20 Mar 2025 at 01:39, Jason @.***> wrote:

I can't reproduce this on Node-RED v4. I'll have to test it on version 3.

— Reply to this email directly, view it on GitHub https://github.com/zachowj/node-red-contrib-home-assistant-websocket/issues/1785#issuecomment-2738811681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENIQ2P3SUKBJNBPGWQOZCT2VIL4PAVCNFSM6AAAAABZJVQI6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZYHAYTCNRYGE . You are receiving this because you authored the thread.Message ID: <zachowj/node-red-contrib-home-assistant-websocket/issues/1785/2738811681@ github.com> [image: zachowj]zachowj left a comment (zachowj/node-red-contrib-home-assistant-websocket#1785) https://github.com/zachowj/node-red-contrib-home-assistant-websocket/issues/1785#issuecomment-2738811681

I can't reproduce this on Node-RED v4. I'll have to test it on version 3.

— Reply to this email directly, view it on GitHub https://github.com/zachowj/node-red-contrib-home-assistant-websocket/issues/1785#issuecomment-2738811681, or unsubscribe https://github.com/notifications/unsubscribe-auth/AENIQ2P3SUKBJNBPGWQOZCT2VIL4PAVCNFSM6AAAAABZJVQI6KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZYHAYTCNRYGE . You are receiving this because you authored the thread.Message ID: <zachowj/node-red-contrib-home-assistant-websocket/issues/1785/2738811681@ github.com>

bwims avatar Mar 20 '25 10:03 bwims

I put v4 up on a test system, and sure enough the problem is gone. (see below) a) can this be fixed for v3 users? b) if not, can you provide a method for reverting?

I think the main problem is the combination of the HA logo, the number and the warning triangle take up too much space. Perhaps make their existence configurable? Or dependent on version number?

It's a big deal to test all my flows under v4 for something as trivial as this. I hope you can help!

Needles to say I'm very grateful for all the work you've put in to provide this facility!

Image

bwims avatar Mar 21 '25 13:03 bwims

Due to the lack of response, am I to assume the answer is "suck it up and upgrade to V4" ? At the very least this should be documented as a breaking change for the version of node-red-contrib-home-assistant-websocket that introduced the weird heading, don't you think?

(The above is not meant in any way to diminish my gratitude for the work put into this project!)

bwims avatar Apr 13 '25 10:04 bwims

Image

bwims avatar May 22 '25 14:05 bwims

I'd be happy to fix this simple CSS bug (it's due to the fact that the header is not a flex container in v3, but it is in v4). However, I don't have HA, so I'm not sure how I can trigger/reproduce any error to show up in the header? Can this be mocked/tested somehow without hooking up a HA instance?

pReya avatar Jul 03 '25 05:07 pReya

@pReya Thanks for the offer. I started to explain where the information could be found but realized it was quicker to just fix the issue myself.

zachowj avatar Jul 04 '25 03:07 zachowj